Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support missing fields in Instance and LKE ACL #618

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Support missing fields in Instance and LKE ACL #618

merged 5 commits into from
Nov 19, 2024

Conversation

yec-akamai
Copy link
Contributor

📝 Description

Support the following missing fields in Instance and LKE ACL for API parity:

  • InstanceBackup
    • last_successful
  • InstanceUpgradeOptions
    • allow_auto_disk_resize
  • InstancePlacementGroup
    • migrating_to
  • LKEClusterControlPlaneACL
    • revision_id
  • LKEClusterControlPlaneACLOptions
    • revision_id

✔️ How to Test

make testunit

make fixtures ARGS="-run TestInstance_Get"

make fixtures ARGS="-run TestLKECluster_withACL"

@yec-akamai yec-akamai added the improvement for improvements in existing functionality in the changelog. label Nov 14, 2024
@yec-akamai yec-akamai requested a review from a team as a code owner November 14, 2024 19:48
@yec-akamai yec-akamai requested review from ykim-akamai and ezilber-akamai and removed request for a team November 14, 2024 19:48
ykim-akamai
ykim-akamai approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests passing locally. Thanks for adding the unit test as well! Nice work!

ezilber-akamai
ezilber-akamai approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing locally. LGTM!

@yec-akamai yec-akamai merged commit f1ff0b9 into main Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

Assignees
No one assigned
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yec-akamai @ykim-akamai @ezilber-akamai