Added support for updated Reserved IP behavior to existing resources (instance, network_ips) #610
Conversation
…d, InsuffecientPermission, ReserveIP, GetReservedIP, getReservedIPs, DeleteReservedIPs
…y appropriate error message along with code
…ord user with adequate permissions
…d fatalf wherever necessary
…es with latest error messages
… feature. Removed for loop to reserve IPs till limit is reached.
…d fixtures to reflect new error messages
* build(deps): bump golang.org/x/oauth2 from 0.22.0 to 0.23.0 Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.22.0 to 0.23.0. - [Commits](golang/oauth2@v0.22.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Ran make tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <[email protected]>
* build(deps): bump golang.org/x/text from 0.17.0 to 0.18.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.17.0 to 0.18.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * make tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ye Chen <[email protected]>
…ing endpoints (linode#573) * Add LKE types endpoints * Support base struct; add NB types endpoints * Add volume types * Add network transfer prices * Add price and region price structs * Revert IPv6 fixtures * Add missing fixtures
…th associated tests
… the corresponding tests and fixtures
…tance to instance_ips.go
…ual test funcitons and removed debugging log statements
…st functions, made changes to error messages
…g addresses of a linode
…nd corresponding tests
…nd recorded new ones for allocating and assigning reserved IPs
Added support for updated Reserved IP behavior to existing resources (instance, network_ips)
AniJ98
requested review from
lgarber-akamai and
ezilber-akamai
and removed request for
a team
test/integration/network_ips_test.go
Outdated
|
|
||
| reservedIP, err = createReservedIP() | ||
| if err == nil { | ||
| t.Fatalf("Expected error indicating MAX IP Reservation limit has been reached, got nil") |
There was a problem hiding this comment.
We typically try to design tests to be account/limit-agnostic so I think we can remove this case
There was a problem hiding this comment.
Got it! I will go ahead and remove this test.
| // AllocateReserveIP allocates a new IPv4 address to the Account, with the option to reserve it | ||
| // and optionally assign it to a Linode. | ||
| func (c *Client) AllocateReserveIP(ctx context.Context, opts LinodeReserveIPOptions) (*InstanceIP, error) { | ||
| e := "networking/ips" |
There was a problem hiding this comment.
This isn't quite related to this PR but I'm curious about what the difference between POST networking/reserved/ips and POST networking/ips (with reserved == true) is. Is the latter effectively just an alias of the former with a bit more functionality?
There was a problem hiding this comment.
That is a good question! We are currently supporting creation of reserved IP's through both POST networking/reserved/ips and POST networking/ips (with reserved == true). The only difference is that along with creation we are also able to assign reserved IP's to linodes using POST networking/ips (with reserved == true).
|
This PR looks great other than a few small things! The CI failure should have been fixed in this PR so merge from main should get the linter passing 🙂 |
…d field in the IPAddressUpdateOptions struct
Removed test for exceeding IP MAX and changed the type of the reserve…
network_ips.go
Outdated
| @@ -16,6 +17,14 @@ type LinodeIPAssignment struct { | |||
| LinodeID int `json:"linode_id"` | |||
| } | |||
|
|
|||
| type LinodeReserveIPOptions struct { | |||
There was a problem hiding this comment.
nitpick: Could this be renamed to AllocateReserveIPOptions?
There was a problem hiding this comment.
Yes! I will make the change now
Changed struct name from LinodeReserveIPOptions to AllocateReserveIPO…
📝 Description
This PR implements functionality and tests for managing Reserved IP addresses in the Linodego client. These changes align with the updated Linode API, providing comprehensive support for Reserved IP operations. The changes include:
Implementation of core operations:
Test coverage:
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
export LINODE_TOKEN="your_token_here"Additionally you need to set the following if you want to test it in a different environment:
LINODE_TOKEN="your_token_here"Run the tests using one of the following commands: To run all integration tests:
make testintTo run a specific test:
go test -v ./integration -run TestInstance_DeleteInstanceVariantsNote:
Ensure that you have enough quota to reserve IP before adding it to an existing linode. Ensure the IPMAX limit is enough to allocate/ assign a reserved IP to a linode.