-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for missing Instance-related endpoints #605
Merged
ezilber-akamai
merged 7 commits into
linode:main
from
ezilber-akamai:TPT-3237-missing-instance-endpoints
Nov 13, 2024
Merged
Added support for missing Instance-related endpoints #605
ezilber-akamai
merged 7 commits into
linode:main
from
ezilber-akamai:TPT-3237-missing-instance-endpoints
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
November 5, 2024 15:02
ezilber-akamai
added
the
improvement
for improvements in existing functionality in the changelog.
label
Nov 5, 2024
ezilber-akamai
force-pushed
the
TPT-3237-missing-instance-endpoints
branch
from
November 5, 2024 16:38
b886a87
to
b922ec3
Compare
jriddle-linode
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, every thing is passing locally!
lgarber-akamai
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing on my end, great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for the following Instance endpoints:
✔️ How to Test
Unit Tests
make testunit
Integration Tests
make fixtures ARGS="-run TestInstance_Disk_Clone"
make fixtures ARGS="-run TestInstance_NodeBalancers_List"
make fixtures ARGS="-run TestInstance_ResetPassword"
make fixtures ARGS="-run TestInstance_GetMonthlyTransfer"
make fixtures ARGS="-run TestInstance_GetTransfer"