Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for missing Instance-related endpoints #605

Merged

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for the following Instance endpoints:

  • POST linode/instances/$1/disks/$2/clone
  • GET linode/instances/$1/nodebalancers
  • POST linode/instances/$1/password
  • GET linode/instances/$1/transfer/$2/$3

✔️ How to Test

Unit Tests

make testunit

Integration Tests

  • make fixtures ARGS="-run TestInstance_Disk_Clone"
  • make fixtures ARGS="-run TestInstance_NodeBalancers_List"
  • make fixtures ARGS="-run TestInstance_ResetPassword"
  • make fixtures ARGS="-run TestInstance_GetMonthlyTransfer"
  • make fixtures ARGS="-run TestInstance_GetTransfer"

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner November 5, 2024 15:02
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team November 5, 2024 15:02
@ezilber-akamai ezilber-akamai added the improvement for improvements in existing functionality in the changelog. label Nov 5, 2024
@ezilber-akamai ezilber-akamai force-pushed the TPT-3237-missing-instance-endpoints branch from b886a87 to b922ec3 Compare November 5, 2024 16:38
instance_disks.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, every thing is passing locally!

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, great work!

@ezilber-akamai ezilber-akamai merged commit d3028f7 into linode:main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants