fix: add missing events #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ActionCommunityLike EventAction = "community_like" | ||
| ActionCreateCardUpdated EventAction = "credit_card_updated" | ||
| ActionDatabaseCreate EventAction = "database_create" | ||
| ActionDatabaseDegraded EventAction = "database_degraded" |
There was a problem hiding this comment.
While we're updating Actions, it looks like these database_method actions aren't listed in the API for Event View?
There was a problem hiding this comment.
Yes, they are missing in the doc, but they exist in this repo before this PR, lol. Let's ask the doc team to take a look.
zliang-akamai
approved these changes
Aug 23, 2023
|
Can confirm the gosec scan alert is a false positive. |
yec-akamai
approved these changes
Aug 23, 2023
amisiorek-akamai
added a commit
that referenced
this pull request
Aug 28, 2023
* adding missing events (#365) * implementation * fixing merge conflict * Update account_events.go Co-authored-by: Lena Garber <[email protected]> --------- Co-authored-by: Jacob Riddle <[email protected]> Co-authored-by: Lena Garber <[email protected]>
lgarber-akamai
added a commit
that referenced
this pull request
Sep 1, 2023
* adding missing events (#365) * Implement region-specific pricing * Add test * Revert go.work.sum * nosec --------- Co-authored-by: Jacob Riddle <[email protected]>
lgarber-akamai
added a commit
that referenced
this pull request
Sep 11, 2023
* adding missing events (#365) * Implement region-specific pricing * Add test * Revert go.work.sum * nosec --------- Co-authored-by: Jacob Riddle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Adding missing events from https://www.linode.com/docs/api/account/#events-list