Support Linode VPC #362
Merged
Support Linode VPC #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
force-pushed
the
zhiwei/vpc
branch
5 times, most recently
from
61fd5ac
to
83d4815
Compare
zliang-akamai
force-pushed
the
zhiwei/vpc
branch
from
83d4815
to
371cd0c
Compare
zliang-akamai
force-pushed
the
zhiwei/vpc
branch
from
371cd0c
to
352e258
Compare
lgarber-akamai
approved these changes
Aug 28, 2023
|
@lgarber-akamai Thanks for the feedback! How does it look now? |
yec-akamai
reviewed
Aug 29, 2023
Co-authored-by: Ye Chen <[email protected]>
yec-akamai
approved these changes
Aug 29, 2023
jriddle-linode
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains implementations for all Linode VPC related APIs. Tests are failing because we can't put fixtures from production server in the repo.
You can pull and do the integration tests against Alpha APIs with commands below.
This will be merged into a feature branch rather than the main branch, and we can merge to main when the API is in production and we can get fixtures from it.
Test
make fixtures ARGS="-run TestVPC"make fixtures ARGS="-run TestInstance_Config"