Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not to override LINODE_URL in Makefile #359

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Not to override LINODE_URL in Makefile #359

merged 1 commit into from
Aug 21, 2023

Conversation

zliang-akamai
Copy link
Member

This is useful for testing against Alpha. Use the environmental variable LINODE_URL when available instead of always override it.

@zliang-akamai zliang-akamai requested a review from a team as a code owner August 16, 2023 20:02
lgarber-akamai
lgarber-akamai approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lgarber-akamai lgarber-akamai requested a review from a team August 16, 2023 20:19
@zliang-akamai zliang-akamai merged commit 9041adc into main Aug 21, 2023
5 checks passed
@zliang-akamai zliang-akamai deleted the not-to-override-env-url-in-makfile branch August 21, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@jriddle-linode jriddle-linode jriddle-linode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zliang-akamai @jriddle-linode @lgarber-akamai