[feat] add support for custom BGP environment overrides via environment variables #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljohnson92
force-pushed
the
support_custom_bgp_environments
branch
from
2751cbb to
9cec7dc
Compare
rahulait
reviewed
Dec 18, 2024
| @@ -481,6 +482,12 @@ func (l *loadbalancers) getCiliumLBIPPool(ctx context.Context, service *v1.Servi | |||
|
|
|||
| // NOTE: Cilium CRDs must be installed for this to work | |||
| func (l *loadbalancers) ensureCiliumBGPPeeringPolicy(ctx context.Context) error { | |||
| if raw, ok := os.LookupEnv("BGPCustomIDMap"); ok { | |||
There was a problem hiding this comment.
Can we add these two environment variables in readme here? https://github.com/linode/linode-cloud-controller-manager?tab=readme-ov-file#additional-environment-variables
Also, should we capitalize the environment variable to match with existing style?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
This PR adds support for two new environment variables in the following formats
BGPPeerPrefix="2600:3c0f"andBGPCustomIDMap='{"nl-ams": 22, "us-southeast": 4}'which combined allows for custom BGP environments.Pull Request Guidelines: