[fix] : use single copy of instances cache #276
Merged
+35
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows CCM to use single copy of instance cache for all controllers. Previously, all controllers were maintaining their own copy of instance cache and were refreshing it when using it.
To test, I intentionally started CCM with flags
- --node-status-update-frequency=20s
and- --linodego-debug=true
which makes CCM to update node status every 20s rather than default 5min. With existing main branch and mentioned flags, I can see it making double calls to linode API for updating cache (one for instance cache kept by route_controller and one by instances controller). With an image from this PR, I can see it makes half of what I see with main branch. It confirms that both controllers are now sharing the same cache.General:
Pull Request Guidelines: