Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo-ci-improvement] : add release-drafter to ccm #269

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[repo-ci-improvement] : add release-drafter to ccm #269

merged 1 commit into from
Dec 12, 2024

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Dec 12, 2024 •
edited
Loading

General:

Adding release-drafter to CCM repo

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@rahulait rahulait added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Dec 12, 2024
komer3
komer3 reviewed Dec 12, 2024
View reviewed changes
.github/workflows/pr-labeler.yml Outdated Show resolved Hide resolved
.github/workflows/release-drafter.yml Outdated Show resolved Hide resolved
@rahulait rahulait force-pushed the release-drafter branch 2 times, most recently from 896725f to aa23c72 Compare December 12, 2024 17:21
komer3
komer3 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahulait rahulait merged commit 99e221f into main Dec 12, 2024
4 checks passed
@rahulait rahulait deleted the release-drafter branch December 19, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komer3 komer3 komer3 approved these changes

Assignees
No one assigned
Labels
repo-ci-improvement for improvements in the repository or CI workflow in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulait @komer3