Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage routes for instances in multiple vpcs in a single region #241

Merged
merged 6 commits into from
Nov 14, 2024

address review comments

5194406
Select commit
Loading
Failed to load commit list.
Merged

manage routes for instances in multiple vpcs in a single region #241

address review comments
5194406
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 1s

56.06% (+0.73%) compared to dc407dd

View this Pull Request on Codecov

56.06% (+0.73%) compared to dc407dd

Details

Codecov Report

Attention: Patch coverage is 73.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 56.06%. Comparing base (dc407dd) to head (5194406).

Files with missing lines Patch % Lines
cloud/linode/vpc.go 60.60% 11 Missing and 2 partials ⚠️
cloud/linode/route_controller.go 86.79% 5 Missing and 2 partials ⚠️
cloud/linode/cloud.go 0.00% 4 Missing and 1 partial ⚠️
cloud/linode/instances.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   55.33%   56.06%   +0.73%     
==========================================
  Files          12       12              
  Lines        2324     2349      +25     
==========================================
+ Hits         1286     1317      +31     
+ Misses        887      881       -6     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.