Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix firewall label length being too long with large svc names #174

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

julsemaan
Copy link
Contributor

@julsemaan julsemaan commented Feb 8, 2024

Addresses an issue where a long k8s service name will create firewall rules labels that are too long (Linode API accepts max 32 chars). This strips the name when too long, leaves it untouched otherwise

fixes #172

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@tchinmai7 tchinmai7 merged commit 8470afb into linode:main Feb 8, 2024
4 checks passed
@julsemaan julsemaan deleted the fix/fw-label-len branch February 8, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall annotation cannot work with long service names
2 participants