-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add linode UUID as a metadata to each node #162
Conversation
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
linodeClient.SetBaseURL(validatedURL.String()) | ||
|
||
version := "" | ||
matches := regexp.MustCompile(`/v\d+`).FindAllString(parsedURL.Path, -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still required after the linodego update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same logic as in the linode-cosi-driver and linode-blockstorage-csi-driver, added there just so we have similar code paths in all 3 components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a dumb question, but why dont we make a linodeClient.ParseURL
which does this logic and sets the base url and version for you. this would move all this logic to the linodego and we could reuse it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lgarber-akamai @zliang-akamai for visibility on my dumb questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @luthermonson, I think you are right. Let us discuss it and get back to you next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late follow-up! I think this is a good idea and I've created a ticket internally to get this implemented ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - agree with uuid
-> host-uuid
change.
e33731b
to
8f0c882
Compare
f1fc47f
to
d8f8b67
Compare
Signed-off-by: Mateusz Urbanek <[email protected]>
d8f8b67
to
3797e68
Compare
Signed-off-by: Mateusz Urbanek <[email protected]>
General:
Pull Request Guidelines:
A host UUID was added to the Linode Instance in a client change: linode/linodego#284
Apply this UUID from the CCM to expose the underlying host uniqueness, can improve scheduling and placement decisions for resources deployed on clusters with CCM installed.