-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linodego to v1 #118
Conversation
59ac07a
to
16c3e7d
Compare
Once #126 gets merged, rebase this and add the following to f := &linodego.Filter{}
f.AddField(linodego.Eq, "ipv4", ipv4)
filter, err := f.MarshalJSON()
if err != nil {
return nil, err
} |
@okokes-akamai it seems this PR is not currently working. Can we convert this to a draft PR until it is in a working state. |
Bumped linodego in e2e deps as well, just haven't had a chance to test it as I have issues with my environment. |
@okokes-akamai if this is still good to go then let's get it merged. could you also bump go to 1.20 while youre in the go.mod? |
@@ -6,10 +6,10 @@ require ( | |||
github.com/appscode/go v0.0.0-20200323182826-54e98e09185a | |||
github.com/getsentry/sentry-go v0.4.0 | |||
github.com/golang/mock v1.6.0 | |||
github.com/linode/linodego v0.32.2 | |||
github.com/linode/linodego v1.14.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think you could go all the way to v1.25.0 now?
This is definitely not ready to be merged, because it has implications for our deployment model due to the linodego URL handling. So we cannot just merge it, because then we'd have to rework our internal systems accordingly (and would thus be blocked from developing CCM until that happens). |
This is being taken care at #143. @okokes-akamai I believe this should be good to close. |
General:
Pull Request Guidelines: