Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.21 in Github Actions #86

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Use Go 1.21 in Github Actions #86

merged 1 commit into from
Feb 7, 2024

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Feb 7, 2024 •
edited
Loading

Go 1.22 is not compatible with controller-gen 0.13:

/home/runner/work/cluster-api-provider-linode/cluster-api-provider-linode/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa0e55e]

goroutine 221 [running]:
go/types.(*Checker).handleBailout(0xc000cef200, 0xc00282bd40)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/check.go:367 +0x88
panic({0xbc8860?, 0x12b9880?})
	/opt/hostedtoolcache/go/1.22.0/x64/src/runtime/panic.go:770 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0xdc4c38, 0x12c2040})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/sizes.go:228 +0x31e
go/types.(*Config).sizeof(...)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/sizes.go:333
go/types.representableConst.func1({0xdc4c38?, 0x12c2040?})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/const.go:76 +0x9e
go/types.representableConst({0xdcb010, 0x128d060}, 0xc000cef200, 0x12c2040, 0xc00284fe28)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/const.go:92 +0x192
go/types.(*Checker).conversion.func1({0xdc4c60?, 0xc000852c40?}, 0xc00284fe28)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/conversions.go:24 +0x[73](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:74)
go/types.(*Checker).conversion(0xc000cef200, 0xc00284fe00, {0xdc4c60, 0xc000852c40})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/conversions.go:44 +0x214
go/types.(*Checker).callExpr(0xc000cef200, 0xc00284fe00, 0xc001044b80)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/call.go:224 +0xc97
go/types.(*Checker).exprInternal(0xc000cef200, 0x0, 0xc00284fe00, {0xdc9380, 0xc001044b80}, {0x0, 0x0})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:13[74](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:75) +0xf8
go/types.(*Checker).rawExpr(0xc000cef200, 0x0, 0xc00284fe00, {0xdc9380?, 0xc001044b80?}, {0x0?, 0x0?}, 0x0)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:979 +0x19e
go/types.(*Checker).exprInternal(0xc000cef200, 0x0, 0xc00284fe00, {0xdc8c60, 0xc001033a60}, {0x0, 0x0})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:1320 +0x178
go/types.(*Checker).rawExpr(0xc000cef200, 0x0, 0xc00284fe00, {0xdc8c60?, 0xc001033a60?}, {0x0?, 0x0?}, 0x0)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:979 +0x19e
go/types.(*Checker).exprOrType(0xc000cef200, 0xc00284fe00, {0xdc8c60?, 0xc001033a60?}, 0xc0?)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:1573 +0x3b
go/types.(*Checker).selector(0xc000cef200, 0xc00284fe00, 0xc0014e3dd0, 0x0, 0x0)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/call.go:[76](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:77)9 +0x592
go/types.(*Checker).exprInternal(0xc000cef200, 0x0, 0xc00284fe00, {0xdc[78](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:79)b0, 0xc0014e3dd0}, {0x0, 0x0})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:1325 +0xd25
go/types.(*Checker).rawExpr(0xc000cef200, 0x0, 0xc00284fe00, {0xdc78b0?, 0xc0014e3dd0?}, {0x0?, 0x0?}, 0x0)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:9[79](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:80) +0x19e
go/types.(*Checker).expr(0xc000cef200, 0x0?, 0xc00284fe00, {0xdc78b0?, 0xc0014e3dd0?})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/expr.go:1513 +0x30
go/types.(*Checker).varDecl(0xc000cef200, 0xc0023f5aa0, {0xc001611000, 0x1, 0x1}, {0x0, 0x0}, {0xdc78b0, 0xc0014e3dd0})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/decl.go:521 +0x17b
go/types.(*Checker).objDecl(0xc000cef200, {0xdd07f8, 0xc0023f5aa0}, 0x0)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/decl.go:194 +0x9e5
go/types.(*Checker).packageObjects(0xc000cef200)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/resolver.go:693 +0x4dd
go/types.(*Checker).checkFiles(0xc000cef200, {0xc002294900, 0x8, 0x8})
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/check.go:408 +0x1a5
go/types.(*Checker).Files(...)
	/opt/hostedtoolcache/go/1.22.0/x64/src/go/types/check.go:372
sigs.k8s.io/controller-tools/pkg/loader.(*loader).typeCheck(0xc000227440, 0xc0002844[80](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:81))
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/loader/loader.go:286 +0x36a
sigs.k8s.io/controller-tools/pkg/loader.(*Package).NeedTypesInfo(0xc0002[84](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:85)480)
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/loader/loader.go:[99](https://github.com/linode/cluster-api-provider-linode/actions/runs/7811358939/job/21306310218?pr=80#step:7:100) +0x39
sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check(0xc000a28f30, 0xc000284480)
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:268 +0x2b7
sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check.func1(0x61?)
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:262 +0x53
created by sigs.k8s.io/controller-tools/pkg/loader.(*TypeChecker).check in goroutine 29
	/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/loader/refs.go:260 +0x1c5

This was referenced Feb 7, 2024
Merged
Merged
Merged
shanduur
shanduur approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@shanduur shanduur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth to create an Issue to not forget to update the go-version to 1.22 (or stable) in the future?

AshleyDumaine
AshleyDumaine approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhmxs mhmxs merged commit 2a0d728 into main Feb 7, 2024
6 checks passed
@mhmxs mhmxs deleted the downgrade-go-ga branch February 7, 2024 16:55
@mhmxs mhmxs mentioned this pull request Feb 8, 2024
Closed
@mhmxs
Copy link
Contributor Author

mhmxs commented Feb 8, 2024

Is it worth to create an Issue to not forget to update the go-version to 1.22 (or stable) in the future?

@shanduur #86

amold1 pushed a commit that referenced this pull request May 17, 2024
@mhmxs
Use Go 1.21 in Github Actions (#86)
239ed4c 
Co-authored-by: Richard Kovacs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanduur shanduur shanduur approved these changes

@AshleyDumaine AshleyDumaine AshleyDumaine approved these changes

@luthermonson luthermonson luthermonson approved these changes

@eljohnson92 eljohnson92 eljohnson92 approved these changes

@zliang-akamai zliang-akamai Awaiting requested review from zliang-akamai

@avestuk avestuk Awaiting requested review from avestuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhmxs @eljohnson92 @luthermonson @AshleyDumaine @shanduur