Machine e2e test with bring your own VPC #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luthermonson
reviewed
Feb 7, 2024
mhmxs
force-pushed
the
e2e-test-machine
branch
3 times, most recently
from
0f95c08 to
7cbdc4c
Compare
mhmxs
force-pushed
the
e2e-byovpc-machine-test
branch
2 times, most recently
from
0df6687 to
4a2acda
Compare
mhmxs
force-pushed
the
e2e-byovpc-machine-test
branch
from
4a2acda to
41047a3
Compare
|
@eljohnson92 @avestuk i rebased this change to main. Please take a look. |
avestuk
approved these changes
Feb 8, 2024
cbzzz
pushed a commit
to cbzzz/cluster-api-provider-linode
that referenced
this pull request
Feb 8, 2024
cbzzz
pushed a commit
to cbzzz/cluster-api-provider-linode
that referenced
this pull request
Feb 8, 2024
cbzzz
pushed a commit
to cbzzz/cluster-api-provider-linode
that referenced
this pull request
Feb 8, 2024
cbzzz
pushed a commit
to cbzzz/cluster-api-provider-linode
that referenced
this pull request
Feb 9, 2024
cbzzz
pushed a commit
that referenced
this pull request
Feb 20, 2024
cbzzz
added a commit
that referenced
this pull request
Feb 20, 2024
* controller: add delete event filter for vpc Updates the `LinodeVPCReconciler` to ignore self-generated delete events. * fixup! Machine e2e test with bring your own VPC (#83) * controller: emit vpc create event * fixup! controller: emit vpc create event
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
Co-authored-by: Richard Kovacs <[email protected]>
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* controller: add delete event filter for vpc Updates the `LinodeVPCReconciler` to ignore self-generated delete events. * fixup! Machine e2e test with bring your own VPC (#83) * controller: emit vpc create event * fixup! controller: emit vpc create event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test suit creates a VPC via raw APi call, and uses the created VPC as a target of Linode machine creation.
Related to: #7