fixup! Missing LINODE_TOKEN error message

[cbzzz]

Description

Addresses: #76 (comment)

Notes

I'm not sure we should be using a global LINODE_TOKEN for the operator (and all it's managed workload clusters) here. We should allow workload clusters to specify the Linode account in which to provision its resources.

[mhmxs]

It makes sense, lots of other project uses setupLog in the same way.

[eljohnson92]

@mhmxs is it expected that the e2e-test failure just because the test is coming from a fork?

[cbzzz]

@mhmxs It seems like the E2E test doesn't have the LINODE_TOKEN environment variable set. Is this expected? Thanks!

https://github.com/linode/cluster-api-provider-linode/actions/runs/7805739210/job/21292435053#step:7:346

[AshleyDumaine]

@cbzzz I think you would need to set the LINODE_TOKEN secret on your fork for GHA to pass: https://github.com/linode/cluster-api-provider-linode/blob/main/.github/workflows/build_test_ci.yml#L139C35-L139C47

[mhmxs]

Is this expected?

@cbzzz I our current setup: Yes

[mhmxs]

set the LINODE_TOKEN

@cbzzz @AshleyDumaine keep in mind, that test execution should cost money. At the time of this we don't have any tests, but this should change soon: #80

[eljohnson92]

I think there is a larger discussion about when we want to run these e2e tests but I don't think that should be blocking on this PR. I'm good to merge as is if there are no other comments