[feat]: Set metadata for LinodeMachines, disable swap #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
force-pushed
the
bootstrap-data
branch
from
5df9f02 to
828108e
Compare
AshleyDumaine
force-pushed
the
bootstrap-data
branch
from
828108e to
9bb835e
Compare
luthermonson
reviewed
Feb 1, 2024
cloud/scope/machine.go
Outdated
| ) | ||
| } | ||
|
|
||
| return b64.StdEncoding.EncodeToString(value), nil |
There was a problem hiding this comment.
should the b64 encoding happen by the callee incase anyone is looking for the string? this feels like a generic function and how it's used shouldn't be determined by this func
luthermonson
reviewed
Feb 1, 2024
| @@ -209,6 +209,9 @@ func (r *LinodeMachineReconciler) reconcile( | |||
| } | |||
| }() | |||
|
|
|||
| // Add the finalizer if not already there | |||
| controllerutil.AddFinalizer(machineScope.LinodeMachine, infrav1.GroupVersion.String()) | |||
There was a problem hiding this comment.
since youre playing with this line could you add a patch like @eljohnson92 PR earlier to cluster https://github.com/linode/cluster-api-provider-linode/pull/64/files#diff-d6148d3b8d79d76ad02a5e26b74a8bbff6541058ae664f3c10e5dd97accffd76R99-R113
There was a problem hiding this comment.
Good call, I'll get that added 👍
AshleyDumaine
changed the title
luthermonson
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
LinodeMachinecontroller to wait for bootstrap data to be ready before creating Linode instances since the cloud-config needs to be stored in the metadata field to configure the Linode properly. Additionally sets swap to be disabled since kubeadm fails with swap enabled.Related issues: