Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: fix status check on created LinodeMachines #73

Merged

Conversation

AshleyDumaine
Copy link
Contributor

I was hitting issues specifically for LinodeMachines that were part of a KubeadmControlPlane. They would be stuck in Provisioning (seems to be the initial status) on the associated Machine and hence they never properly reconciled to where they were actually created on the Linode side.

e.g.:

k get cluster-api
NAME                                                                      CLUSTER      AGE
kubeadmconfig.bootstrap.cluster.x-k8s.io/adumaine-1-control-plane-hvb2q   adumaine-1   4m46s
kubeadmconfig.bootstrap.cluster.x-k8s.io/adumaine-1-md-0-ww2w2            adumaine-1   4m47s

NAME                                                               AGE
kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/adumaine-1-md-0   4m47s

NAME                                  CLUSTERCLASS   PHASE          AGE     VERSION
cluster.cluster.x-k8s.io/adumaine-1                  Provisioning   4m47s

NAME                                                 CLUSTER      REPLICAS   READY   UPDATED   UNAVAILABLE   PHASE       AGE     VERSION
machinedeployment.cluster.x-k8s.io/adumaine-1-md-0   adumaine-1   1                  1         1             ScalingUp   4m47s   v1.28.3

NAME                                                      CLUSTER      NODENAME   PROVIDERID                  PHASE          AGE     VERSION
machine.cluster.x-k8s.io/adumaine-1-control-plane-zsd8k   adumaine-1                                          Provisioning   4m46s   v1.28.3
machine.cluster.x-k8s.io/adumaine-1-md-0-gjwqk-gf9h5      adumaine-1              linode:///us-ord/54495767   Provisioned    4m47s   v1.28.3

NAME                                                CLUSTER      REPLICAS   READY   AVAILABLE   AGE     VERSION
machineset.cluster.x-k8s.io/adumaine-1-md-0-gjwqk   adumaine-1   1                              4m47s   v1.28.3

NAME                                                                         CLUSTER      INITIALIZED   API SERVER AVAILABLE   REPLICAS   READY   UPDATED   UNAVAILABLE   AGE     VERSION
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/adumaine-1-control-plane   adumaine-1                                        1                  1         1             4m47s   v1.28.3

NAME                                                       CLUSTER      READY
linodecluster.infrastructure.cluster.x-k8s.io/adumaine-1   adumaine-1   false

NAME                                                                           CLUSTER      STATE     READY   INSTANCEID                  MACHINE
linodemachine.infrastructure.cluster.x-k8s.io/adumaine-1-control-plane-tk8d9   adumaine-1                                                 adumaine-1-control-plane-zsd8k
linodemachine.infrastructure.cluster.x-k8s.io/adumaine-1-md-0-pwzfc            adumaine-1   running   false   linode:///us-ord/54495767   adumaine-1-md-0-gjwqk-gf9h5

NAME                                                                             AGE
linodemachinetemplate.infrastructure.cluster.x-k8s.io/adumaine-1-control-plane   4m47s
linodemachinetemplate.infrastructure.cluster.x-k8s.io/adumaine-1-md-0            4m47s

Removing this phase from the skipped phases resolves the issue and the Machine / LinodeMachine gets properly created:

k get cluster-api
NAME                                                                      CLUSTER      AGE
kubeadmconfig.bootstrap.cluster.x-k8s.io/adumaine-2-control-plane-f8slt   adumaine-2   4m39s
kubeadmconfig.bootstrap.cluster.x-k8s.io/adumaine-2-md-0-fmzmq            adumaine-2   4m40s

NAME                                                               AGE
kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/adumaine-2-md-0   4m40s

NAME                                  CLUSTERCLASS   PHASE          AGE     VERSION
cluster.cluster.x-k8s.io/adumaine-2                  Provisioning   4m40s

NAME                                                 CLUSTER      REPLICAS   READY   UPDATED   UNAVAILABLE   PHASE       AGE     VERSION
machinedeployment.cluster.x-k8s.io/adumaine-2-md-0   adumaine-2   1                  1         1             ScalingUp   4m40s   v1.28.3

NAME                                                      CLUSTER      NODENAME   PROVIDERID                  PHASE         AGE     VERSION
machine.cluster.x-k8s.io/adumaine-2-control-plane-kwwfs   adumaine-2              linode:///us-ord/54502711   Provisioned   4m39s   v1.28.3
machine.cluster.x-k8s.io/adumaine-2-md-0-bcd6f-7cdff      adumaine-2              linode:///us-ord/54502710   Provisioned   4m40s   v1.28.3

NAME                                                CLUSTER      REPLICAS   READY   AVAILABLE   AGE     VERSION
machineset.cluster.x-k8s.io/adumaine-2-md-0-bcd6f   adumaine-2   1                              4m40s   v1.28.3

NAME                                                                         CLUSTER      INITIALIZED   API SERVER AVAILABLE   REPLICAS   READY   UPDATED   UNAVAILABLE   AGE     VERSION
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/adumaine-2-control-plane   adumaine-2                                        0                  0         0             4m40s   v1.28.3

NAME                                                       CLUSTER      READY
linodecluster.infrastructure.cluster.x-k8s.io/adumaine-2   adumaine-2   true

NAME                                                                           CLUSTER      STATE     READY   INSTANCEID                  MACHINE
linodemachine.infrastructure.cluster.x-k8s.io/adumaine-2-control-plane-5k6cx   adumaine-2   running   false   linode:///us-ord/54502711   adumaine-2-control-plane-kwwfs
linodemachine.infrastructure.cluster.x-k8s.io/adumaine-2-md-0-j8bzs            adumaine-2   running   false   linode:///us-ord/54502710   adumaine-2-md-0-bcd6f-7cdff

NAME                                                                             AGE
linodemachinetemplate.infrastructure.cluster.x-k8s.io/adumaine-2-control-plane   4m40s
linodemachinetemplate.infrastructure.cluster.x-k8s.io/adumaine-2-md-0            4m40s

@eljohnson92 eljohnson92 merged commit 1bfa6dc into linode:main Jan 31, 2024
5 checks passed
@AshleyDumaine AshleyDumaine deleted the fix-control-plane-provisioning branch January 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants