Introduce VPC controller #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmxs
force-pushed
the
vpc-controller
branch
2 times, most recently
from
cccf3fd to
cb4cb2c
Compare
mhmxs
force-pushed
the
vpc-controller
branch
6 times, most recently
from
59d34b9 to
e723014
Compare
eljohnson92
reviewed
Jan 29, 2024
mhmxs
force-pushed
the
vpc-controller
branch
3 times, most recently
from
fd84967 to
5af0987
Compare
avestuk
reviewed
Feb 1, 2024
|
I have tested this and confirmed a VPC is created and |
eljohnson92
approved these changes
Feb 1, 2024
luthermonson
approved these changes
Feb 1, 2024
Co-authored-by: Alex Vest <[email protected]>
Co-authored-by: Alex Vest <[email protected]>
|
@eljohnson92 @avestuk I addressedd all the review items, so could you please do the final review (one more commit) and it should be ready to merge. |
avestuk
approved these changes
Feb 5, 2024
eljohnson92
approved these changes
Feb 5, 2024
cbzzz
pushed a commit
to cbzzz/cluster-api-provider-linode
that referenced
this pull request
Feb 8, 2024
cbzzz
pushed a commit
that referenced
this pull request
May 15, 2024
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* Introduce VPC controller * Requeue non empty vpc deletion * Filter out not found in vpc controller patch * Update controller/linodemachine_controller.go Co-authored-by: Alex Vest <[email protected]> * Update controller/linodemachine_controller_helpers.go Co-authored-by: Alex Vest <[email protected]> * update CRD creation for VPC and setup VPC Controller in main.go * Remove vpc list copy before sort --------- Co-authored-by: Richard Kovacs <[email protected]> Co-authored-by: Alex Vest <[email protected]> Co-authored-by: Evan Johnson <[email protected]>
cbzzz
pushed a commit
that referenced
this pull request
May 21, 2024
cbzzz
pushed a commit
that referenced
this pull request
May 22, 2024
cbzzz
added a commit
that referenced
this pull request
May 22, 2024
* fixup! Introduce VPC controller (#62) * feat: linodevpc: kubebuilder create webhook Scaffold a validating admission webhook for the LinodeVPC resource with Kubebuider via the command: kubebuilder create webhook --group infrastructure --version v1alpha1 --kind LinodeVPC --programmatic-validation * fixup! feat: linodevpc: kubebuilder create webhook * golangci: configure varnamelen * api: linodevpc: add create validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new controller to manage VPCs on Linode. The Cluster object has an optional
vpcReference field. The customer should bring them own VPC by setting thelabelfield to the custom resource to pointing to an existing VPC. The machine controller also has been updated to attach new instances to the VPC.Fixes: #4