[fix] golangci-lint is unlocked to use the latest version again #489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
golangci-lint was locked to use v1.59.1 in this PR #455.
It is switched back to use the latest verison and all the lint updates are taken care of.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
The breaking upgrade that golangci-lint latest brought in was mandating passing of format strings for Printf and similar functions.
For example:
Printf and similar functions are usually called with a literal format string, followed by zero or more arguments.
Even though Printf(v) is accepted, it is not the best way. This format string will fail if v string has unexpected percent sign.
Function calls have been modified to look like: conditions.MarkFalse(machineScope.LinodeMachine, ConditionPreflightRootDiskResized, string(cerrs.CreateMachineError), clusterv1.ConditionSeverityWarning, "%s", err.Error())
This is better way to handle all types of cases where the intended use was a literal format string. Printf("%s", v).
Other updates are pretty self explanatory.
Special notes for your reviewer:
TODOs: