Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement requeues for vpc controller #299

Merged
merged 6 commits into from
May 6, 2024
Merged

Implement requeues for vpc controller #299

merged 6 commits into from
May 6, 2024

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented May 1, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@bcm820 bcm820 marked this pull request as draft May 3, 2024 18:38
@bcm820 bcm820 marked this pull request as ready for review May 6, 2024 15:55
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 66.18%. Comparing base (0ff8a1c) to head (f63b920).

Files Patch % Lines
controller/linodevpc_controller.go 72.22% 9 Missing and 1 partial ⚠️
controller/linodemachine_controller.go 16.66% 4 Missing and 1 partial ⚠️
util/helpers.go 0.00% 5 Missing ⚠️
util/reconciler/conditions.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   64.87%   66.18%   +1.31%     
==========================================
  Files          30       30              
  Lines        1842     1872      +30     
==========================================
+ Hits         1195     1239      +44     
+ Misses        592      575      -17     
- Partials       55       58       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcm820 bcm820 requested a review from komer3 May 6, 2024 17:46
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bcm820 bcm820 merged commit cb6614d into main May 6, 2024
9 of 10 checks passed
@bcm820 bcm820 deleted the requeue-vpc branch May 6, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants