Adding cluster unpause reconcile for LinodeObjectStorageBucket and LinodeVPC #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 50.46% 50.56% +0.10%
==========================================
Files 27 27
Lines 1496 1493 -3
==========================================
Hits 755 755
+ Misses 708 705 -3
Partials 33 33 ☔ View full report in Codecov by Sentry. |
nesv
reviewed
Apr 8, 2024
AshleyDumaine
pushed a commit
that referenced
this pull request
Apr 19, 2024
…nodeVPC (#245) --------- Co-authored-by: Khaja Omer <[email protected]>
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
…nodeVPC (#245) --------- Co-authored-by: Khaja Omer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
We want to be able to rerun the reconcile loop for obj and vpc when they are moved to a target cluster and the cluster is unpaused. This will allow us to make sure LinodeOBJ and LinodeVPCs were moved correctly without any missing resources.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: