Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Requeue during machine preflight #242

Merged
merged 8 commits into from
Apr 9, 2024
Merged

[fix] Requeue during machine preflight #242

merged 8 commits into from
Apr 9, 2024

Conversation

bcm820
Copy link
Contributor

@bcm820 bcm820 commented Apr 8, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 57.02479% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 50.46%. Comparing base (645b584) to head (fb51ade).
Report is 6 commits behind head on main.

Files Patch % Lines
controller/linodemachine_controller.go 47.91% 43 Missing and 7 partials ⚠️
util/reconciler/conditions.go 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   42.35%   50.46%   +8.11%     
==========================================
  Files          26       27       +1     
  Lines        1419     1496      +77     
==========================================
+ Hits          601      755     +154     
+ Misses        804      708      -96     
- Partials       14       33      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcm820 bcm820 marked this pull request as ready for review April 8, 2024 18:22
cloud/scope/common.go Outdated Show resolved Hide resolved
Copy link

@nesv nesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @bcm820!

@bcm820 bcm820 merged commit 65979ca into main Apr 9, 2024
8 checks passed
@bcm820 bcm820 deleted the requeues branch April 9, 2024 12:48
amold1 pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants