Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to turn off private IPs and fix some misc api spec fields #240

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

eljohnson92
Copy link
Collaborator

@eljohnson92 eljohnson92 commented Apr 5, 2024

What type of PR is this?
/kind feature
/kind cleanup

What this PR does / why we need it:
This PR does the following:

  • adds support for turning of private IP
  • add linodevpc & linodeobjectstorage controllers to the cluster-api group
  • add short name lvpc for linodeVPC object
  • print ready status when getting a linodevpc
  • fixes ID and IP capitalization in our CRDs
    The diff unfortunately got very screwed up while moving the bootstrap logic into it's own setupUserdata function but the main change for private IP support is just
if machineScope.LinodeMachine.Spec.PrivateIP != nil {
   	createConfig.PrivateIP = *machineScope.LinodeMachine.Spec.PrivateIP
   } else {
   	createConfig.PrivateIP = true
   }

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@eljohnson92 eljohnson92 force-pushed the support_no_privateip branch from db53b41 to cc40b15 Compare April 5, 2024 19:51
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 44.54%. Comparing base (645b584) to head (9b79d57).

Files Patch % Lines
controller/linodemachine_controller_helpers.go 90.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   42.35%   44.54%   +2.19%     
==========================================
  Files          26       26              
  Lines        1419     1430      +11     
==========================================
+ Hits          601      637      +36     
+ Misses        804      779      -25     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
controller/linodemachine_controller_helpers.go Outdated Show resolved Hide resolved
@eljohnson92 eljohnson92 force-pushed the support_no_privateip branch 4 times, most recently from b5bc1cb to 91bd9e6 Compare April 8, 2024 12:55
@AshleyDumaine AshleyDumaine self-requested a review April 8, 2024 15:01
@eljohnson92 eljohnson92 force-pushed the support_no_privateip branch from 91bd9e6 to 9b79d57 Compare April 8, 2024 15:19
Copy link

@nesv nesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljohnson92 eljohnson92 merged commit ed921db into main Apr 8, 2024
8 checks passed
@eljohnson92 eljohnson92 deleted the support_no_privateip branch April 8, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants