-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to turn off private IPs and fix some misc api spec fields #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljohnson92
force-pushed
the
support_no_privateip
branch
from
April 5, 2024 19:51
db53b41
to
cc40b15
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 42.35% 44.54% +2.19%
==========================================
Files 26 26
Lines 1419 1430 +11
==========================================
+ Hits 601 637 +36
+ Misses 804 779 -25
Partials 14 14 ☔ View full report in Codecov by Sentry. |
nesv
suggested changes
Apr 5, 2024
eljohnson92
force-pushed
the
support_no_privateip
branch
4 times, most recently
from
April 8, 2024 12:55
b5bc1cb
to
91bd9e6
Compare
eljohnson92
force-pushed
the
support_no_privateip
branch
from
April 8, 2024 15:19
91bd9e6
to
9b79d57
Compare
AshleyDumaine
approved these changes
Apr 8, 2024
nesv
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
This PR does the following:
linodevpc
&linodeobjectstorage
controllers to thecluster-api
grouplvpc
for linodeVPC objectlinodevpc
ID
andIP
capitalization in our CRDsThe diff unfortunately got very screwed up while moving the
bootstrap
logic into it's ownsetupUserdata
function but the main change for private IP support is justWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: