Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release scripts to run tests before publishing an image #236

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

eljohnson92
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.35%. Comparing base (e3566e4) to head (7347671).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   42.35%   42.35%           
=======================================
  Files          26       26           
  Lines        1419     1419           
=======================================
  Hits          601      601           
  Misses        804      804           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

komer3
komer3 previously approved these changes Apr 4, 2024
Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eljohnson92 eljohnson92 force-pushed the update_releaes_workflow branch from 09d71bb to 7347671 Compare April 4, 2024 16:17
Copy link
Contributor

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljohnson92 eljohnson92 merged commit ca3cd20 into main Apr 4, 2024
8 checks passed
@eljohnson92 eljohnson92 deleted the update_releaes_workflow branch April 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants