Clusterctl move operation clean up plus adding necessary labels for obj and vpc #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 42.10% 42.10%
=======================================
Files 25 25
Lines 1375 1375
=======================================
Hits 579 579
Misses 783 783
Partials 13 13 ☔ View full report in Codecov by Sentry. |
eljohnson92
reviewed
Apr 2, 2024
eljohnson92
approved these changes
Apr 3, 2024
AshleyDumaine
pushed a commit
that referenced
this pull request
Apr 19, 2024
…bj and vpc (#228) * Adding labels for to CRDs so clusterctl discovery mechnism works --------- Co-authored-by: Khaja Omer <[email protected]>
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
…bj and vpc (#228) * Adding labels for to CRDs so clusterctl discovery mechnism works --------- Co-authored-by: Khaja Omer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
It just cleans up some code in the
LinodeClusterandLinodeMachinecontrollers.Also add move-hierarchy label to
LinodeObjectStorageBucketandLinodeVPCCRs so that during the move operation, CRs and all the resources owned by them get moved to the new mgmt cluster.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #210
Special notes for your reviewer:
TODOs: