-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use URL from linodego create response for etcd-backup endpoint #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 42.08% 42.10% +0.02%
==========================================
Files 25 25
Lines 1371 1375 +4
==========================================
+ Hits 577 579 +2
- Misses 781 783 +2
Partials 13 13 ☔ View full report in Codecov by Sentry. |
bcm820
reviewed
Mar 27, 2024
bcm820
previously approved these changes
Mar 28, 2024
4 tasks
amold1
added
go
Pull requests that update Go code
obj
Dealing with Linode Object Storage
testing
Pull requests that improve tests
labels
Mar 28, 2024
eljohnson92
approved these changes
Mar 28, 2024
amold1
added a commit
that referenced
this pull request
May 17, 2024
* Use URL from linodego create response for etcd-backup endpoint * fix tests * Switch to using json encoding for tags to allow for underscores * Use upstream image as default and use bucket name from secret for STORAGE_CONTAINER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Use URL from linodego create response for etcd-backup endpoint
What this PR does / why we need it:
This will allow us to use the hostname response from creating the Linode OBJ bucket as the endpoint for the etcd-backup-restore