Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL from linodego create response for etcd-backup endpoint #218

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Mar 27, 2024

What type of PR is this?
Use URL from linodego create response for etcd-backup endpoint

What this PR does / why we need it:
This will allow us to use the hostname response from creating the Linode OBJ bucket as the endpoint for the etcd-backup-restore

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@amold1 amold1 self-assigned this Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 42.10%. Comparing base (93ee1c0) to head (2b47320).
Report is 3 commits behind head on main.

Files Patch % Lines
cloud/scope/object_storage_bucket.go 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   42.08%   42.10%   +0.02%     
==========================================
  Files          25       25              
  Lines        1371     1375       +4     
==========================================
+ Hits          577      579       +2     
- Misses        781      783       +2     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amold1 amold1 marked this pull request as ready for review March 27, 2024 14:28
@amold1 amold1 requested review from bcm820 and eljohnson92 March 27, 2024 14:28
bcm820
bcm820 previously approved these changes Mar 28, 2024
@amold1 amold1 requested a review from bcm820 March 28, 2024 13:21
@amold1 amold1 added go Pull requests that update Go code obj Dealing with Linode Object Storage testing Pull requests that improve tests labels Mar 28, 2024
@amold1 amold1 merged commit 585a8dc into main Mar 28, 2024
8 checks passed
@amold1 amold1 deleted the etcdbackup.endpoint branch March 28, 2024 14:06
amold1 added a commit that referenced this pull request May 17, 2024
* Use URL from linodego create response for etcd-backup endpoint

* fix tests

* Switch to using json encoding for tags to allow for underscores

* Use upstream image as default and use bucket name from secret for STORAGE_CONTAINER
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code obj Dealing with Linode Object Storage testing Pull requests that improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants