-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the cluster-api operator for tilt installs instead of clusterctl #217
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 42.10% 42.10%
=======================================
Files 25 25
Lines 1375 1375
=======================================
Hits 579 579
Misses 783 783
Partials 13 13 ☔ View full report in Codecov by Sentry. |
5b96f5b
to
a918c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, we won't be able to use clusterclt move
. Which can be an issue since people who create a mgmt cluster using make local-deploy
won't be able to utilize clusterclt functionality completely.
@Komer I think the operator sets the right labels?
|
1fb83f0
to
ad46f52
Compare
ad46f52
to
c592aa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR replaces
clusterctl init ...
local_commands in tilt with usage of the cluster-api operator and installs of the resources directly. The main benefit of doing it this way is we can easily stream container logs and see the health of the various parts of the CAPL installation. this otherwise should be a no-op for other workflowsWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: