Unit tests for cloud/scope/common.go #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
added
testing
bcm820
reviewed
Mar 7, 2024
bcm820
reviewed
Mar 7, 2024
bcm820
reviewed
Mar 7, 2024
eljohnson92
reviewed
Mar 7, 2024
bcm820
reviewed
Mar 8, 2024
cloud/scope/common_test.go
Outdated
| expectedError string | ||
| }{ | ||
| { | ||
| name: "Check is the function works correctly", |
There was a problem hiding this comment.
The test description is a bit generic. Can you describe what's specific to this test case? i.e. "gets an apiToken from the Secret in a different namespace"
AshleyDumaine
approved these changes
Mar 8, 2024
AshleyDumaine
approved these changes
Mar 8, 2024
eljohnson92
approved these changes
Mar 8, 2024
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* Added test cases to get max test coverage for common.go --------- Co-authored-by: Khaja Omer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Created Unit tests for the cloud/scope/common.go file using gomock and mockgen to mock external dependencies.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: