feat: extend multi-tenancy for LinodeMachines #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates LinodeMachines to be able to supply an (optional) CredentialsRef field to override the credentials of their owner LinodeCluster. This allows clusters to provision Linode resources cross-account.
eljohnson92
approved these changes
Mar 5, 2024
|
LGTM |
AshleyDumaine
approved these changes
Mar 5, 2024
4 tasks
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
* feat: extend multi-tenancy for LinodeMachines Updates LinodeMachines to be able to supply an (optional) CredentialsRef field to override the credentials of their owner LinodeCluster. This allows clusters to provision Linode resources cross-account. * docs: update multi-tenant clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates LinodeMachines to be able to supply an (optional) CredentialsRef field to override the credentials of their owner LinodeCluster.
This allows for a (potentially future) enhancement where clusters can provision Linode resources cross-account.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This is being introduced now (rather than when the feature is determined to be absolutely needed) to provide a more stable API during development. However, we may wait to add this feature since:
TODOs: