Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update controller-gen, rename csi-driver to better short-name #150

Closed
wants to merge 1 commit into from

Conversation

srust
Copy link
Contributor

@srust srust commented Feb 28, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@srust
Copy link
Contributor Author

srust commented Feb 28, 2024

Hey, for some reason my controller-gen version changed. How's the best way to undo this? Otherwise, this PR is pretty small. Thanks!

@srust srust requested a review from eljohnson92 February 28, 2024 23:00
@eljohnson92
Copy link
Collaborator

these changes look good to me, looks like a local devbox update caused the new controller-gen and other tools to be pulled in. I would be fine with merging in the devbox updates as well

@AshleyDumaine AshleyDumaine added dependencies Pull requests that update a dependency file cleanup anything cleanup related labels Feb 29, 2024
@AshleyDumaine AshleyDumaine changed the title Rename csi-driver to better short-name. update controller-gen, rename csi-driver to better short-name Feb 29, 2024
@AshleyDumaine
Copy link
Contributor

@srust
Copy link
Contributor Author

srust commented Feb 29, 2024

Replaced by #158

@srust srust closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup anything cleanup related dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants