[tweak] - Switch linode labels to LinodeMachine Name instead of UID #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komer3
changed the title
eljohnson92
reviewed
Feb 28, 2024
| @@ -41,7 +41,7 @@ func (r *LinodeVPCReconciler) reconcileVPC(ctx context.Context, vpcScope *scope. | |||
| } | |||
|
|
|||
| if createConfig.Label == "" { | |||
| createConfig.Label = util.RenderObjectLabel(vpcScope.LinodeVPC.UID) | |||
There was a problem hiding this comment.
are there other usages of renderObjectLabel? or can this function be deleted?
There was a problem hiding this comment.
Yeah, my IDE shows no other usages so we should be safe to remove this
There was a problem hiding this comment.
Deleted the function. It doesn't affect anything else
|
Aside from cleaning up the |
AshleyDumaine
approved these changes
Feb 28, 2024
AshleyDumaine
changed the title
eljohnson92
approved these changes
Feb 28, 2024
4 tasks
amold1
pushed a commit
that referenced
this pull request
May 17, 2024
…-{UID} (#143)
Co-authored-by: Khaja Omer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR switched to using linode machine names instead of UID for less confusion
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: