Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add k3s flavor support #139

Merged
merged 2 commits into from
Feb 27, 2024
Merged

add k3s flavor support #139

merged 2 commits into from
Feb 27, 2024

Conversation

eljohnson92
Copy link
Collaborator

@eljohnson92 eljohnson92 commented Feb 26, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds template support for k3s as a flavor when generating a cluster. it does require that the k3s bootstrap/controlplane providers are already installed and also that you specify a k3s specific k8s version

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

templates/flavors/k3s/secret.yaml Outdated Show resolved Hide resolved
templates/flavors/k3s/secret.yaml Outdated Show resolved Hide resolved
templates/flavors/k3s/secret.yaml Show resolved Hide resolved
@AshleyDumaine AshleyDumaine added the feature New feature or request label Feb 26, 2024
@eljohnson92 eljohnson92 marked this pull request as ready for review February 26, 2024 21:50
docs/src/flavors/flavors.md Outdated Show resolved Hide resolved
docs/src/topics/getting-started.md Outdated Show resolved Hide resolved
docs/src/topics/getting-started.md Outdated Show resolved Hide resolved
docs/src/flavors/clusterclass-kubeadm.md Outdated Show resolved Hide resolved
docs/src/flavors/clusterclass-kubeadm.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljohnson92 eljohnson92 merged commit 7e71668 into main Feb 27, 2024
6 checks passed
@eljohnson92 eljohnson92 deleted the k3s-template branch February 27, 2024 18:46
@AshleyDumaine AshleyDumaine added documentation Improvements or additions to documentation k3s Pull requests pertaining to the k3s flavor labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request k3s Pull requests pertaining to the k3s flavor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants