Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat, docs] - Add ClusterClass support and create flavors #130

Merged
merged 12 commits into from
Feb 23, 2024
Merged

[feat, docs] - Add ClusterClass support and create flavors #130

merged 12 commits into from
Feb 23, 2024

Conversation

AshleyDumaine
Copy link
Contributor

@AshleyDumaine AshleyDumaine commented Feb 21, 2024 •
edited
Loading

Additions

  • Toggles on the ClusterClass feature gate for the KIND cluster created via Tilt
  • Adds a new "clusterclass-kubeadm" flavor
  • Uses kustomize to generate the flavors
  • Adds a new make target and hack script to generate flavors

Changes

  • Reorders and cleans up the development doc in the book

Deletions

  • Removes unused make run target
  • Removes templates/cluster-template*.yaml to reduce confusion (the generated templates via kustomize should not be directly edited)
    • 💬 Discussion: I'm open to keeping these in here but to do so we'll need more work to verify the templates are always up-to-date and include some kind of comment that the files are autogenerated and not to edit them directly.

@AshleyDumaine AshleyDumaine changed the base branch from release-process to main February 21, 2024 21:02
@AshleyDumaine AshleyDumaine marked this pull request as ready for review February 21, 2024 21:06
@AshleyDumaine AshleyDumaine force-pushed the cluster-class-support branch 2 times, most recently from 0e435c9 to bf43f95 Compare February 22, 2024 14:35
@AshleyDumaine AshleyDumaine marked this pull request as draft February 22, 2024 14:40
@AshleyDumaine AshleyDumaine force-pushed the cluster-class-support branch 2 times, most recently from a47325e to 1e27ff6 Compare February 22, 2024 16:07
@AshleyDumaine AshleyDumaine marked this pull request as ready for review February 22, 2024 19:04
eljohnson92
eljohnson92 reviewed Feb 23, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
eljohnson92
eljohnson92 reviewed Feb 23, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@AshleyDumaine AshleyDumaine merged commit 651c54c into main Feb 23, 2024
6 checks passed
@AshleyDumaine AshleyDumaine deleted the cluster-class-support branch February 23, 2024 19:37
amold1 pushed a commit that referenced this pull request May 17, 2024
@AshleyDumaine
[feat, docs] - Add ClusterClass support and create flavors (#130)
571199c 
* start adding flavors enable cluster topology feature gate for Tilt

* generate flavors as part of release

* restructure and update development docs

* update docs for clusterclass

* install cilium in kube-system NS on provisioned clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljohnson92 eljohnson92 eljohnson92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshleyDumaine @eljohnson92