cloud/scope: fix: only patch objects missing finalizer

Fixes the `AddFinalizers` scope methods to only patch their objects when the finalizer is
missing. This prevents unncessary `resourceVersion` changes to the object.

cloud/scope/cluster.go

@@ -91,9 +91,11 @@ func (s *ClusterScope) Close(ctx context.Context) error {
 	return s.PatchObject(ctx)
 }
 
-// AddFinalizer adds a finalizer and immediately patches the object to avoid any race conditions
+// AddFinalizer adds a finalizer if not present and immediately patches the
+// object to avoid any race conditions.
 func (s *ClusterScope) AddFinalizer(ctx context.Context) error {
-	controllerutil.AddFinalizer(s.LinodeCluster, infrav1alpha1.GroupVersion.String())
-
-	return s.Close(ctx)
+	if controllerutil.AddFinalizer(s.LinodeCluster, infrav1alpha1.GroupVersion.String()) {
+		return s.Close(ctx)
+	}
+	return nil
 }

cloud/scope/machine.go

@@ -85,11 +85,13 @@ func (s *MachineScope) Close(ctx context.Context) error {
 	return s.PatchObject(ctx)
 }
 
-// AddFinalizer adds a finalizer and immediately patches the object to avoid any race conditions
+// AddFinalizer adds a finalizer if not present and immediately patches the
+// object to avoid any race conditions.
 func (s *MachineScope) AddFinalizer(ctx context.Context) error {
-	controllerutil.AddFinalizer(s.LinodeMachine, infrav1alpha1.GroupVersion.String())
-
-	return s.Close(ctx)
+	if controllerutil.AddFinalizer(s.LinodeMachine, infrav1alpha1.GroupVersion.String()) {
+		return s.Close(ctx)
+	}
+	return nil
 }
 
 // GetBootstrapData returns the bootstrap data from the secret in the Machine's bootstrap.dataSecretName.

cloud/scope/vpc.go

@@ -84,9 +84,11 @@ func (s *VPCScope) Close(ctx context.Context) error {
 	return s.PatchObject(ctx)
 }
 
-// AddFinalizer adds a finalizer and immediately patches the object to avoid any race conditions
+// AddFinalizer adds a finalizer if not present and immediately patches the
+// object to avoid any race conditions.
 func (s *VPCScope) AddFinalizer(ctx context.Context) error {
-	controllerutil.AddFinalizer(s.LinodeVPC, infrav1alpha1.GroupVersion.String())
-
-	return s.Close(ctx)
+	if controllerutil.AddFinalizer(s.LinodeVPC, infrav1alpha1.GroupVersion.String()) {
+		return s.Close(ctx)
+	}
+	return nil
 }