[controller] use Utils::getRealTimeTopicName in tests
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
71e47bf
to
f66bf8f
Compare
arjun4084346
commented
Nov 26, 2024
| @@ -86,7 +86,6 @@ public Route requestTopicForPushing(Admin admin) { | |||
| && (!hasWriteAccessToTopic(request) || (this.checkReadMethodForKafka && !hasReadAccessToTopic(request)))) { | |||
| response.status(HttpStatus.SC_FORBIDDEN); | |||
| String userId = getPrincipalId(request); | |||
| String storeName = request.queryParams(NAME); | |||
There was a problem hiding this comment.
removed unused string
arjun4084346
commented
Nov 26, 2024
| @@ -282,13 +282,18 @@ private void populateDeprecatedTopicQueue(PriorityQueue<PubSubTopic> topics) { | |||
| Map<String, Map<PubSubTopic, Long>> allStoreTopics = getAllVeniceStoreTopicsRetentions(topicsWithRetention); | |||
| allStoreTopics.forEach((storeName, topicRetentions) -> { | |||
| int minNumOfUnusedVersionTopicsOverride = minNumberOfUnusedKafkaTopicsToPreserve; | |||
| PubSubTopic realTimeTopic = pubSubTopicRepository.getTopic(Version.composeRealTimeTopic(storeName)); | |||
There was a problem hiding this comment.
got rid of composeRealTimeTopic api
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
f66bf8f
to
32eca34
Compare
arjun4084346
changed the title
arjun4084346
changed the title
arjun4084346
changed the title
Utils::getRealTimeTopicName in tests
…code will also use Utils.getRealTimeTopicName Utils.getRealTimeTopicName returns the same value as Version.composeRealTimeTopic as of now, so we are able to make changes in any order
arjun4084346
force-pushed
the
rttopicname-part-2
branch
from
32eca34
to
4d09147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change references for
Version::composeRealTimeTopictoUtils::getRealTimeTopicNameThis is the continuation work of #1345
Changing references for
Version::composeRealTimeTopictoUtils::getRealTimeTopicName. Because there are too many references to review easily, only references in test files are changed in this PR.Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?