Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Added java.md to developer docs #1348

Merged
merged 4 commits into from
Nov 27, 2024
Merged

[docs] Added java.md to developer docs #1348

merged 4 commits into from
Nov 27, 2024

Conversation

FelixGV
Copy link
Contributor

@FelixGV FelixGV commented Nov 26, 2024

Other minor changes:

  • Added instructions to avoid double brace init in the sytle guide.

  • Tweaked learn_more.md to include additional podcast links.

  • Added several SVG icons under the assets directory and sprinkled them over a few pages.

How was this PR tested?

Doc changes can be seen on my fork. The following links have changed:

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@FelixGV
[docs] Added java.md to developer docs
bd1f38f 
Other minor changes:

- Added instructions to avoid double brace init in the sytle
  guide.

- Tweaked learn_more.md to include additional podcast links.

- Added several SVG icons under the assets directory and
  sprinkled them over a few pages.
@FelixGV
Minor tweak to alignment-related doc.
179459b
@FelixGV
Added links to Shipilev's blog about word tearing and scalar replacem…
f05fa30 
…ent.
majisourav99
majisourav99 previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@majisourav99 majisourav99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for helpful docs!

@FelixGV
- Reordered the first two sections for a better flow.
0b558a5 
- Added mention of JS in the "other languages".
- Added details to volatile accesses.
majisourav99
majisourav99 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@majisourav99 majisourav99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including the node.js reference :)

@FelixGV FelixGV merged commit ee20094 into linkedin:main Nov 27, 2024
51 checks passed
@FelixGV
Copy link
Contributor Author

FelixGV commented Nov 27, 2024

Thanks for the review @majisourav99 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majisourav99 majisourav99 majisourav99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FelixGV @majisourav99