[controller][admin-tool][vpj][test] Add a multi-region config to controllers and cleanup many configs #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisargthakkar
force-pushed
the
multiRegionBackendConfig
branch
6 times, most recently
from
6f6dbeb
to
495f03f
Compare
…rollers and infer many configs
1. Use multi.region config to control certain features instead of controlling them via explicit configs.
* Native-replication - Enabled in multi-region mode. Disabled in single-region mode.
* Admin channel consumption - Enabled in multi-region mode. Disabled in single-region mode.
* This is still allowed to be disabled via LiveConfig for store migration purposes.
* Controller allowing BATCH push via API - Disabled in multi-region mode. Enabled in single-region mode.
* Active-active replication enabled on a controller - Enabled in multi-region mode. Disabled in single-region mode.
2. Commands and code to enable and disable Native-replication for a cluster has been removed as that is the only mode.
3. The following configs are now obsolete, and removed:
* enable.native.replication.for.batch.only
* enable.native.replication.for.batch.only
* enable.native.replication.for.hybrid
* enable.native.replication.as.default.for.batch.only
* enable.native.replication.as.default.for.hybrid
* enable.active.active.replication.as.default.for.batch.only.store
* enable.active.active.replication.as.default.for.batch.only.store
* admin.topic.remote.consumption.enabled
* child.controller.admin.topic.consumption.enabled
* Only removed from controller config
* It is still used in LiveConfigs during store migration
* active.active.enabled.on.controller
* controller.enable.batch.push.from.admin.in.child
4. The following configs were unused and now removed:
* kafka.min.log.compaction.lag.ms
* topic.cleanup.send.concurrent.delete.requests.enabled
* topic.deletion.status.poll.interval.ms
* topic.creation.throttling.time.window.ms
* topic.manager.kafka.operation.timeout.ms
* admin.consumption.timeout.minute
* amplification.factor
* server.ingestion.isolation.metric.request.timeout.seconds
nisargthakkar
force-pushed
the
multiRegionBackendConfig
branch
from
495f03f
to
ccc4583
Compare
nisargthakkar
changed the title
nisargthakkar
changed the title
2 tasks
mynameborat
reviewed
Jul 24, 2024
internal/venice-common/src/main/java/com/linkedin/venice/utils/Utils.java
Outdated
Show resolved
Hide resolved
internal/venice-common/src/test/java/com/linkedin/venice/utils/UtilsTest.java
Show resolved
Hide resolved
...on/src/integrationTest/java/com/linkedin/venice/controller/AbstractTestVeniceHelixAdmin.java
Outdated
Show resolved
Hide resolved
...linkedin/venice/controller/TestEnablingSSLPushInVeniceHelixAdminWithIsolatedEnvironment.java
Show resolved
Hide resolved
...ionTest/java/com/linkedin/venice/controller/TestVeniceHelixAdminWithIsolatedEnvironment.java
Show resolved
Hide resolved
...-test-common/src/integrationTest/java/com/linkedin/venice/controller/TestFabricBuildout.java
Show resolved
Hide resolved
...ationTest/java/com/linkedin/venice/controller/TestVeniceHelixAdminWithSharedEnvironment.java
Show resolved
Hide resolved
nisargthakkar
force-pushed
the
multiRegionBackendConfig
branch
2 times, most recently
from
ed70e58
to
37d6763
Compare
nisargthakkar
force-pushed
the
multiRegionBackendConfig
branch
from
37d6763
to
32f69a6
Compare
|
Looks good to me. If you can remove the unused constructor that would be good. |
mynameborat
approved these changes
Jul 25, 2024
|
Thanks a lot @mynameborat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
multi.regionconfig to controllers and cleanup many other configsHow was this PR tested?
GH CI
Does this PR introduce any user-facing changes?