Skip to content

Commit

Permalink
[server][controller] Disable topic existence check in consumer subscr…
Browse files Browse the repository at this point in the history
…ibe API (#768)
  • Loading branch information
sushantmane authored Nov 21, 2023
1 parent 8ea3a55 commit 96503fd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ public class PubSubConstants {
public static final int PUBSUB_CONSUMER_TOPIC_QUERY_RETRY_INTERVAL_MS_DEFAULT_VALUE = 1000;

public static final String PUBSUB_CONSUMER_CHECK_TOPIC_EXISTENCE = "pubsub.consumer.check.topic.existence";
public static final boolean PUBSUB_CONSUMER_CHECK_TOPIC_EXISTENCE_DEFAULT_VALUE = true;
public static final boolean PUBSUB_CONSUMER_CHECK_TOPIC_EXISTENCE_DEFAULT_VALUE = false;
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.linkedin.venice.pubsub.api.consumer;

import static com.linkedin.venice.pubsub.PubSubConstants.PUBSUB_CONSUMER_CHECK_TOPIC_EXISTENCE;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
Expand Down Expand Up @@ -112,6 +113,7 @@ public void setUpMethod() {
String.valueOf(PUBSUB_CONSUMER_API_DEFAULT_TIMEOUT_MS));
properties.putAll(pubSubBrokerWrapper.getAdditionalConfig());
properties.putAll(pubSubBrokerWrapper.getMergeableConfigs());
properties.put(PUBSUB_CONSUMER_CHECK_TOPIC_EXISTENCE, "true");
VeniceProperties veniceProperties = new VeniceProperties(properties);

pubSubConsumerAdapter = pubSubClientsFactory.getConsumerAdapterFactory()
Expand Down

0 comments on commit 96503fd

Please sign in to comment.