Upgrade async http client #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current usages of async http client when making SSL connections is having issues. Upgrading the client, similar to pinot in this PR apache/pinot#7968
cbrentharris
force-pushed
the
upgrade-async-http-client
branch
from
6162033
to
95b9d34
Compare
zackthehuman
requested changes
Jan 23, 2024
Comment on lines
+22
to
27
| public static synchronized AsyncHttpClient getAsyncHttpClient() { | ||
| if (_client.get() == null) { | ||
| initialize(new AsyncHttpClientConfig.Builder().build()); | ||
| initialize(new Builder().build()); | ||
| } | ||
| return _client.get(); | ||
| } |
There was a problem hiding this comment.
I think we should instead introduce getAsyncHttpClient() alongside getNingClient() and mark getNingClient() as @Deprecated. I know the type has changed, and there's nothing we can do about that, but there are users of this code that will break if getNingClient() disappears on a minor version bump.
There was a problem hiding this comment.
I need to confer with the team about the other breaking changes.
There was a problem hiding this comment.
The only concern I would have with that is if ning needs a different version of netty (or other) that the new project needs. What are your thoughts on that behavior? Would you like to see the dependency resolution for netty?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project has moved to a new repo; please refer to apache/pinot#7968 and AsyncHttpClient/async-http-client#934 for motivation