Skip to content

Commit

Permalink
Mark mask-type as a presentation attribute.
Browse files Browse the repository at this point in the history
Closes #692
  • Loading branch information
RazrFalcon committed Jan 3, 2024
1 parent cb52988 commit 67ca118
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ This changelog also contains important changes in dependencies.
- `usvg::NodeExt`. No longer needed.
- `usvg::Node::calculate_bbox`. Use `usvg::Node::abs_bounding_box`.

### Fixed
- Mark `mask-type` as a presentation attribute.

## [0.37.0] - 2023-12-16
### Added
- `usvg` can write text back to SVG now.
Expand Down
1 change: 1 addition & 0 deletions crates/resvg/tests/integration/render.rs
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ use crate::render;
#[test] fn masking_mask_mask_on_self_with_mask_type_eq_alpha() { assert_eq!(render("tests/masking/mask/mask-on-self-with-mask-type=alpha"), 0); }
#[test] fn masking_mask_mask_on_self_with_mixed_mask_type() { assert_eq!(render("tests/masking/mask/mask-on-self-with-mixed-mask-type"), 0); }
#[test] fn masking_mask_mask_on_self() { assert_eq!(render("tests/masking/mask/mask-on-self"), 0); }
#[test] fn masking_mask_mask_type_in_style() { assert_eq!(render("tests/masking/mask/mask-type-in-style"), 0); }
#[test] fn masking_mask_mask_type_eq_alpha() { assert_eq!(render("tests/masking/mask/mask-type=alpha"), 0); }
#[test] fn masking_mask_mask_type_eq_invalid() { assert_eq!(render("tests/masking/mask/mask-type=invalid"), 0); }
#[test] fn masking_mask_mask_type_eq_luminance() { assert_eq!(render("tests/masking/mask/mask-type=luminance"), 0); }
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions crates/resvg/tests/tests/masking/mask/mask-type-in-style.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions crates/usvg-parser/src/svgtree/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,7 @@ impl AId {
| AId::MarkerMid
| AId::MarkerStart
| AId::Mask
| AId::MaskType
| AId::MixBlendMode // technically not presentation
| AId::Opacity
| AId::Overflow
Expand Down

0 comments on commit 67ca118

Please sign in to comment.