Update docs and labels for CXR-3 release #227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-aboutalebi
requested changes
Jun 3, 2022
| @@ -75,7 +75,7 @@ def eval( | |||
| parser.add_argument('--metaname', default='model.meta', type=str, help='Name of ckpt meta file') | |||
| parser.add_argument('--ckptname', default='model', type=str, help='Name of model ckpts') | |||
| parser.add_argument('--n_classes', default=2, type=int, help='Number of detected classes, defaults to 2') | |||
| parser.add_argument('--testfile', default='labels/test_COVIDx9B.txt', type=str, help='Name of testfile') | |||
There was a problem hiding this comment.
Same here. test_COVIDx9B does not give me any information on what version it is being used. It makes it also difficult to track previous versions.
There was a problem hiding this comment.
let's just focus on the new release and not cleaning up the old ones. For the new datasets COVIDx CXR 3A and 3B, do you think it would just be clearer if it was COVIDx CXR3-2class and CXR3-3class?
There was a problem hiding this comment.
Yeah it might be clearer that way, we can use that scheme going forward.
h-aboutalebi
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add cleaned CXR-3 label files, update README and COVIDx docs.
Context of change
Please add options that are relevant and mark any boxes that apply.
Type of change
Please mark any boxes that apply.
How Has This Been Tested?
N/A
Checklist:
Please mark any boxes that have been completed.