Skip to content

Commit

Permalink
#126 Address QA items
Browse files Browse the repository at this point in the history 
Update notice style value to em vs. rem to better theme integration
Remove callout class to avoid clashing styles with Foundation themes
Remove empty bullets from the Go Pro details page
  • Loading branch information
@maxinacube
maxinacube committed Jul 2, 2020
1 parent 8379863 commit dd55357
Show file tree
Hide file tree
Showing 13 changed files with 2,687 additions and 47 deletions.
6 changes: 3 additions & 3 deletions assets/scss/config/_mixins.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@

.courier-icon {
text-align: center;
width: 2.5rem;
width: 2.5em;

position: absolute;
left: 0;
Expand All @@ -157,7 +157,7 @@

&[data-closable] {
.courier-content-wrapper {
padding-right: 3rem;
padding-right: 3em;
}

.courier-close {
Expand Down Expand Up @@ -208,7 +208,7 @@

@if ( $icon != false and $icon != '' ) {
.courier-content-wrapper {
padding-left: 3rem;
padding-left: 3em;
}
}
}
2 changes: 1 addition & 1 deletion assets/scss/config/_variables.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ $notice-default-secondary: #cecece;
//Other Global items
$global-radius: .25rem;
$courier-max-content-width: 100%;
$courier-padding: .75rem 1rem .75rem 3rem;
$courier-padding: .75em 1em .75em 3em;

// 03. Animations
$global_timing: 300ms;
Expand Down
18 changes: 11 additions & 7 deletions assets/scss/frontend/_notices.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@

a.close {
position: absolute;
top: 1rem;
right: 1rem;
height: 2rem;
width: 2rem;
line-height: 2rem;
top: 1em;
right: 1em;
height: 2em;
width: 2em;
line-height: 2em;
text-align: center;
background: rgba( $medium-gray, .75);
border: 1px solid rgba( $white, .6 );
Expand All @@ -90,10 +90,14 @@
position: relative;
text-align: center;
background: $white;
min-height: 5rem;
min-height: 5em;
max-height: 80vh;
overflow-y: scroll;
width: 80vw;
max-width: 50rem;
max-width: 50em;
}

.courier-content {
padding: 1em;
}
}
18 changes: 9 additions & 9 deletions css/courier-notices-admin.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
position: relative;
margin: 0 auto;
max-width: 100%;
padding: 0.75rem 1rem 0.75rem 3rem; }
padding: 0.75em 1em 0.75em 3em; }
.courier-notice .courier-content-wrapper:before, .courier-notice .courier-content-wrapper:after {
position: absolute;
left: 0;
Expand All @@ -148,7 +148,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
margin-bottom: 0; }
.courier-notice .courier-icon {
text-align: center;
width: 2.5rem;
width: 2.5em;
position: absolute;
left: 0;
top: 0;
Expand All @@ -162,7 +162,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
top: 50%;
transform: translateY(-50%); }
.courier-notice[data-closable] .courier-content-wrapper {
padding-right: 3rem; }
padding-right: 3em; }
.courier-notice[data-closable] .courier-close {
position: absolute;
right: 0;
Expand All @@ -185,7 +185,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier_type-primary a {
color: #222; }
.courier_type-primary .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier_type-primary + .courier_type-primary {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -198,7 +198,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier_type-success a {
color: #222; }
.courier_type-success .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier_type-success + .courier_type-success {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -211,7 +211,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier_type-alert a {
color: #222; }
.courier_type-alert .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier_type-alert + .courier_type-alert {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -224,7 +224,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier_type-warning a {
color: #222; }
.courier_type-warning .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier_type-warning + .courier_type-warning {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -237,7 +237,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier_type-feedback a {
color: #222; }
.courier_type-feedback .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier_type-feedback + .courier_type-feedback {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -250,7 +250,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier_type-info a {
color: #222; }
.courier_type-info .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier_type-info + .courier_type-info {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand Down
34 changes: 18 additions & 16 deletions css/courier-notices.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
position: relative;
margin: 0 auto;
max-width: 100%;
padding: 0.75rem 1rem 0.75rem 3rem; }
padding: 0.75em 1em 0.75em 3em; }
.courier-notices .courier-notice .courier-content-wrapper:before, .courier-notices .courier-notice .courier-content-wrapper:after {
position: absolute;
left: 0;
Expand All @@ -154,7 +154,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
margin-bottom: 0; }
.courier-notices .courier-notice .courier-icon {
text-align: center;
width: 2.5rem;
width: 2.5em;
position: absolute;
left: 0;
top: 0;
Expand All @@ -168,7 +168,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
top: 50%;
transform: translateY(-50%); }
.courier-notices .courier-notice[data-closable] .courier-content-wrapper {
padding-right: 3rem; }
padding-right: 3em; }
.courier-notices .courier-notice[data-closable] .courier-close {
position: absolute;
right: 0;
Expand All @@ -191,7 +191,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier-notices .courier_type-primary a {
color: #222; }
.courier-notices .courier_type-primary .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier-notices .courier_type-primary + .courier_type-primary {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -204,7 +204,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier-notices .courier_type-success a {
color: #222; }
.courier-notices .courier_type-success .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier-notices .courier_type-success + .courier_type-success {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -217,7 +217,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier-notices .courier_type-alert a {
color: #222; }
.courier-notices .courier_type-alert .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier-notices .courier_type-alert + .courier_type-alert {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -230,7 +230,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier-notices .courier_type-warning a {
color: #222; }
.courier-notices .courier_type-warning .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier-notices .courier_type-warning + .courier_type-warning {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -243,7 +243,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier-notices .courier_type-feedback a {
color: #222; }
.courier-notices .courier_type-feedback .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier-notices .courier_type-feedback + .courier_type-feedback {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand All @@ -256,7 +256,7 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
.courier-notices .courier_type-info a {
color: #222; }
.courier-notices .courier_type-info .courier-content-wrapper {
padding-left: 3rem; }
padding-left: 3em; }
.courier-notices .courier_type-info + .courier_type-info {
border-top: 2px solid rgba(0, 0, 0, 0.05);
margin-top: -2px; }
Expand Down Expand Up @@ -292,11 +292,11 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
align-content: center; }
.courier-modal-overlay a.close {
position: absolute;
top: 1rem;
right: 1rem;
height: 2rem;
width: 2rem;
line-height: 2rem;
top: 1em;
right: 1em;
height: 2em;
width: 2em;
line-height: 2em;
text-align: center;
background: rgba(173, 167, 157, 0.75);
border: 1px solid rgba(255, 255, 255, 0.6);
Expand All @@ -307,8 +307,10 @@ body.wp-admin table.courier_notice_page_courier [class*="icon-"] {
position: relative;
text-align: center;
background: #FFFFFF;
min-height: 5rem;
min-height: 5em;
max-height: 80vh;
overflow-y: scroll;
width: 80vw;
max-width: 50rem; }
max-width: 50em; }
.courier-modal-overlay .courier-content {
padding: 1em; }
2,083 changes: 2,081 additions & 2 deletions js/courier-notices-admin.js
View file

Large diffs are not rendered by default.

Loading

0 comments on commit dd55357

Please sign in to comment.