Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch with all my mods that aren't overhauls #8

Open
wants to merge 54 commits into
base: develop
Choose a base branch
from

Conversation

lilDavid
Copy link
Owner

@lilDavid lilDavid commented Jul 19, 2023

@lilDavid lilDavid force-pushed the enhancement_mods branch 4 times, most recently from 1d8f740 to d74c639 Compare December 21, 2023 15:07
Malkierian and others added 4 commits December 31, 2023 13:58
* Fix the calculation of `areaChecksGotten` to account for flags functionality setting invisible checks.
Change `areaChecksTotal` to dynamic calculation based on tracker visibility, now that all checks are being added to `checksByArea`.
Both are updated in realtime when either "Show all GS locations" or "Hide right side shop items" are toggled.
Reformat all remaining unencapsulated if statements.

* Changed helper variable change and call to `RecalculateAreaTotals()` to when the options are toggled instead of checking every frame.
Removed redundant if...else.
Clarified areaChecksGotten increment/decrement functionality based on current status and incoming status change.

* Removed unused code.
Archez and others added 30 commits January 15, 2024 09:25
…3808)

* fix tektite death texture loading

* add string header
…hes don't produce a stack trace from which to glean that information. (HarbourMasters#3786)
…ourMasters#3827)

* Restore Original Scene_CommandObjectList Behaviour

* remove some vrom stuff

* add some comments
* add map palettes per pulse to leverage shader caching

* use unregister blended with kaleido maps

* use Gfx_TextureCacheDelete for KD lava

* bump lus

* add miss tex clears for KD
…e DL reference (HarbourMasters#3810)

* move ruto earing fix to real patch

* use stringpath for ganon rubble
Adds helper info for invert, distance, and transition speed options.
* Adds `FormatLocations` and `PRESET_ENTRY_TYPE_CPP_STRING` to allow for feeding `RandomizerCheck` values directly in presets instead of a string with magic numbers.

* Switch to concatenation with `std::to_string`.

* Forgot to remove <format> include XD
* cullzone

* better cvar name

* Update soh/src/code/z_actor.c

* Update soh/src/code/z_actor.c

---------

Co-authored-by: Garrett Cox <[email protected]>
…sters#3878)

* Account for removed object dependency in Deku Scrub Leader

* Update soh/src/overlays/actors/ovl_En_Dnt_Jiji/z_en_dnt_jiji.c

---------

Co-authored-by: Garrett Cox <[email protected]>
…urMasters#3904)

* dont let k overflow

* Update soh/soh/z_scene_otr.cpp

Co-authored-by: Archez <[email protected]>

---------

Co-authored-by: Archez <[email protected]>
…ricks tabs to get around issue with saving blank CVar strings. (HarbourMasters#3916)
* Moves personal notes to the save file under a new itemTracker save section.

* Update soh/soh/Enhancements/randomizer/randomizer_item_tracker.cpp

---------

Co-authored-by: Archez <[email protected]>
…sters#3979)

* Add `SohModalWindow` and `SohModal`. Runs as window, always "visible", but not drawing if no popups are registered.

Adds error catching for save file corruption (malformed json) that renames the file in question to prevent future loading issues and uses `SohModalWindow` to inform the user of the error.

* Apply suggestions from code review

---------

Co-authored-by: briaguya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants