Ako/fix analytics break on local (deriv-com#11033)

* build: use version 1.3.7 of analytics package * fix: to initialize the analytics on staging and production * feat: init analytics on test links too * fix: null check before calling
likhith-deriv · Oct 30, 2023 · e54ca0e · e54ca0e
1 parent 37dea7c
commit e54ca0e
Show file tree

Hide file tree

Showing 8 changed files with 25,475 additions and 68,861 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -92,7 +92,7 @@
     },
     "dependencies": {
         "@babel/preset-typescript": "^7.16.5",
-        "@deriv/analytics": "^1.3.4",
+        "@deriv/analytics": "^1.3.7",
         "@sendbird/chat": "^4.9.7",
         "@types/react-transition-group": "^4.4.4",
         "babel-jest": "^27.3.1",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -89,7 +89,7 @@
         "@babel/polyfill": "^7.4.4",
         "@datadog/browser-rum": "^4.37.0",
         "@deriv/account": "^1.0.0",
-        "@deriv/analytics": "^1.3.4",
+        "@deriv/analytics": "^1.3.7",
         "@deriv/api": "^1.0.0",
         "@deriv/appstore": "^0.0.4",
         "@deriv/wallets": "^1.0.0",

diff --git a/packages/core/src/App/Containers/Layout/app-contents.jsx b/packages/core/src/App/Containers/Layout/app-contents.jsx
@@ -45,20 +45,20 @@ const AppContents = observer(({ children }) => {
 
     React.useEffect(() => {
         if (is_logged_in && user_id) {
-            const { tracking } = Analytics.getInstances();
-            Analytics.setAttributes({
+            const { tracking } = Analytics?.getInstances();
+            Analytics?.setAttributes({
                 account_type: loginid.substring(0, 2),
             });
             tracking.identifyEvent(user_id, {
                 language: getLanguage().toLowerCase() || 'en',
             });
-            Analytics.pageView(current_page);
+            Analytics?.pageView(current_page);
         }
         if (scroll_ref.current) setAppContentsScrollRef(scroll_ref);
         // eslint-disable-next-line react-hooks/exhaustive-deps
     }, []);
 
-    Analytics.pageView(current_page);
+    Analytics?.pageView(current_page);
 
     React.useEffect(() => {
         const allow_tracking = !is_eu_country || tracking_status === 'accepted';

diff --git a/packages/core/src/App/app.jsx b/packages/core/src/App/app.jsx
@@ -50,16 +50,21 @@ const AppWithoutTranslation = ({ root_store }) => {
         };
 
         initializeTranslations();
-
-        Analytics.initialise({
-            growthbookKey: process.env.GROWTHBOOK_CLIENT_KEY,
-            growthbookDecryptionKey: process.env.GROWTHBOOK_DECRYPTION_KEY,
-            rudderstackKey:
-                process.env.NODE_ENV === 'production'
-                    ? process.env.RUDDERSTACK_PRODUCTION_KEY
-                    : process.env.RUDDERSTACK_STAGING_KEY,
-            enableDevMode: process.env.NODE_ENV !== 'production',
-        });
+        if (
+            process.env.NODE_ENV === 'production' ||
+            process.env.NODE_ENV === 'staging' ||
+            process.env.NODE_ENV === 'test'
+        ) {
+            Analytics.initialise({
+                growthbookKey: process.env.GROWTHBOOK_CLIENT_KEY,
+                growthbookDecryptionKey: process.env.GROWTHBOOK_DECRYPTION_KEY,
+                rudderstackKey:
+                    process.env.NODE_ENV === 'production'
+                        ? process.env.RUDDERSTACK_PRODUCTION_KEY
+                        : process.env.RUDDERSTACK_STAGING_KEY,
+                enableDevMode: process.env.NODE_ENV !== 'production',
+            });
+        }
 
         // TODO: [translation-to-shared]: add translation implemnentation in shared
         setUrlLanguage(getLanguage());

diff --git a/packages/core/src/Stores/client-store.js b/packages/core/src/Stores/client-store.js
@@ -1678,7 +1678,7 @@ export default class ClientStore extends BaseStore {
                     language: getLanguage().toLowerCase(),
                 });
                 const current_page = window.location.hostname + window.location.pathname;
-                Analytics.pageView(current_page);
+                Analytics?.pageView(current_page);
 
                 await this.root_store.gtm.pushDataLayer({
                     event: 'login',

diff --git a/packages/reports/package.json b/packages/reports/package.json
@@ -75,7 +75,7 @@
         "webpack-node-externals": "^2.5.2"
     },
     "dependencies": {
-        "@deriv/analytics": "^1.3.4",
+        "@deriv/analytics": "^1.3.7",
         "@deriv/components": "^1.0.0",
         "@deriv/deriv-api": "^1.0.13",
         "@deriv/shared": "^1.0.0",

diff --git a/packages/trader/package.json b/packages/trader/package.json
@@ -84,7 +84,7 @@
         "webpack-node-externals": "^2.5.2"
     },
     "dependencies": {
-        "@deriv/analytics": "^1.3.4",
+        "@deriv/analytics": "^1.3.7",
         "@deriv/components": "^1.0.0",
         "@deriv/deriv-api": "^1.0.13",
         "@deriv/api-types": "^1.0.118",