-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: remove exotic build targets from release list #9318
Conversation
With this commit we remove build targets from our list of release build OS/architecture pairs to reduce the overhead of building for them with every pull request and every release. According to https://tooomm.github.io/github-release-stats/?username=lightningnetwork&repository=lnd those targets are rarely used, compared to the most popular ones: | Release File | Absolute DL | Relative DL | |---------------------------------------|-------------|-------------| | lnd-darwin-amd64-v0.18.3-beta.tar.gz | 1,930 | 72 | | lnd-darwin-arm64-v0.18.3-beta.tar.gz | 2,020 | 162 | | lnd-freebsd-386-v0.18.3-beta.tar.gz | 1,864 | 6 | | lnd-freebsd-amd64-v0.18.3-beta.tar.gz | 1,874 | 16 | | lnd-freebsd-arm-v0.18.3-beta.tar.gz | 1,865 | 7 | | lnd-linux-386-v0.18.3-beta.tar.gz | 1,873 | 15 | | lnd-linux-amd64-v0.18.3-beta.tar.gz | 3,355 | 1,497 | | lnd-linux-arm64-v0.18.3-beta.tar.gz | 3,053 | 1,195 | | lnd-linux-armv6-v0.18.3-beta.tar.gz | 1,868 | 10 | | lnd-linux-armv7-v0.18.3-beta.tar.gz | 1,893 | 35 | | lnd-linux-mips-v0.18.3-beta.tar.gz | 1,859 | 1 | | lnd-linux-mips64-v0.18.3-beta.tar.gz | 1,860 | 2 | | lnd-linux-mipsle-v0.18.3-beta.tar.gz | 1,859 | 1 | | lnd-linux-ppc64-v0.18.3-beta.tar.gz | 1,858 | 0 | | lnd-linux-ppc64le-v0.18.3-beta.tar.gz | 1,859 | 1 | | lnd-linux-s390x-v0.18.3-beta.tar.gz | 1,859 | 1 | | lnd-netbsd-amd64-v0.18.3-beta.tar.gz | 1,859 | 1 | | lnd-openbsd-amd64-v0.18.3-beta.tar.gz | 1,861 | 3 | | lnd-source-v0.18.3-beta.tar.gz | 1,863 | 5 | | lnd-windows-386-v0.18.3-beta.zip | 1,895 | 37 | | lnd-windows-amd64-v0.18.3-beta.zip | 1,997 | 139 | | lnd-windows-arm-v0.18.3-beta.zip | 1,868 | 10 |
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
Cross compile failed with:
Perhaps a cache issue? |
Yes, the cache from previous builds plus the current build just grows too large and completely fills the disk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⏰
Dropped all caches from the GitHub builds now, let's see if that fixes the "cross compile" step in future PRs. |
With this commit we remove build targets from our list of release build OS/architecture pairs to reduce the overhead of building for them with every pull request and every release.
According to https://tooomm.github.io/github-release-stats/?username=lightningnetwork&repository=lnd those targets are rarely used, compared to the most popular ones:
Users of those more exotic systems will still be able to compile
lnd
from source.Anyone not in agreement with the removal of these systems from the release binary target list, please speak up now!