Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: remove exotic build targets from release list #9318

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Nov 28, 2024

With this commit we remove build targets from our list of release build OS/architecture pairs to reduce the overhead of building for them with every pull request and every release.

According to https://tooomm.github.io/github-release-stats/?username=lightningnetwork&repository=lnd those targets are rarely used, compared to the most popular ones:

Release File Absolute DL Relative DL
lnd-darwin-amd64-v0.18.3-beta.tar.gz 1,930 72
lnd-darwin-arm64-v0.18.3-beta.tar.gz 2,020 162
lnd-freebsd-386-v0.18.3-beta.tar.gz 1,864 6
lnd-freebsd-amd64-v0.18.3-beta.tar.gz 1,874 16
lnd-freebsd-arm-v0.18.3-beta.tar.gz 1,865 7
lnd-linux-386-v0.18.3-beta.tar.gz 1,873 15
lnd-linux-amd64-v0.18.3-beta.tar.gz 3,355 1,497
lnd-linux-arm64-v0.18.3-beta.tar.gz 3,053 1,195
lnd-linux-armv6-v0.18.3-beta.tar.gz 1,868 10
lnd-linux-armv7-v0.18.3-beta.tar.gz 1,893 35
lnd-linux-mips-v0.18.3-beta.tar.gz 1,859 1
lnd-linux-mips64-v0.18.3-beta.tar.gz 1,860 2
lnd-linux-mipsle-v0.18.3-beta.tar.gz 1,859 1
lnd-linux-ppc64-v0.18.3-beta.tar.gz 1,858 0
lnd-linux-ppc64le-v0.18.3-beta.tar.gz 1,859 1
lnd-linux-s390x-v0.18.3-beta.tar.gz 1,859 1
lnd-netbsd-amd64-v0.18.3-beta.tar.gz 1,859 1
lnd-openbsd-amd64-v0.18.3-beta.tar.gz 1,861 3
lnd-source-v0.18.3-beta.tar.gz 1,863 5
lnd-windows-386-v0.18.3-beta.zip 1,895 37
lnd-windows-amd64-v0.18.3-beta.zip 1,997 139
lnd-windows-arm-v0.18.3-beta.zip 1,868 10

Users of those more exotic systems will still be able to compile lnd from source.

Anyone not in agreement with the removal of these systems from the release binary target list, please speak up now!

With this commit we remove build targets from our list of release build
OS/architecture pairs to reduce the overhead of building for them with
every pull request and every release.

According to https://tooomm.github.io/github-release-stats/?username=lightningnetwork&repository=lnd
those targets are rarely used, compared to the most popular ones:

| Release File                          | Absolute DL | Relative DL |
|---------------------------------------|-------------|-------------|
| lnd-darwin-amd64-v0.18.3-beta.tar.gz  | 1,930       | 72          |
| lnd-darwin-arm64-v0.18.3-beta.tar.gz  | 2,020       | 162         |
| lnd-freebsd-386-v0.18.3-beta.tar.gz   | 1,864       | 6           |
| lnd-freebsd-amd64-v0.18.3-beta.tar.gz | 1,874       | 16          |
| lnd-freebsd-arm-v0.18.3-beta.tar.gz   | 1,865       | 7           |
| lnd-linux-386-v0.18.3-beta.tar.gz     | 1,873       | 15          |
| lnd-linux-amd64-v0.18.3-beta.tar.gz   | 3,355       | 1,497       |
| lnd-linux-arm64-v0.18.3-beta.tar.gz   | 3,053       | 1,195       |
| lnd-linux-armv6-v0.18.3-beta.tar.gz   | 1,868       | 10          |
| lnd-linux-armv7-v0.18.3-beta.tar.gz   | 1,893       | 35          |
| lnd-linux-mips-v0.18.3-beta.tar.gz    | 1,859       | 1           |
| lnd-linux-mips64-v0.18.3-beta.tar.gz  | 1,860       | 2           |
| lnd-linux-mipsle-v0.18.3-beta.tar.gz  | 1,859       | 1           |
| lnd-linux-ppc64-v0.18.3-beta.tar.gz   | 1,858       | 0           |
| lnd-linux-ppc64le-v0.18.3-beta.tar.gz | 1,859       | 1           |
| lnd-linux-s390x-v0.18.3-beta.tar.gz   | 1,859       | 1           |
| lnd-netbsd-amd64-v0.18.3-beta.tar.gz  | 1,859       | 1           |
| lnd-openbsd-amd64-v0.18.3-beta.tar.gz | 1,861       | 3           |
| lnd-source-v0.18.3-beta.tar.gz        | 1,863       | 5           |
| lnd-windows-386-v0.18.3-beta.zip      | 1,895       | 37          |
| lnd-windows-amd64-v0.18.3-beta.zip    | 1,997       | 139         |
| lnd-windows-arm-v0.18.3-beta.zip      | 1,868       | 10          |
@guggero guggero requested review from Roasbeef and saubyk November 28, 2024 08:51
Copy link
Contributor

coderabbitai bot commented Nov 28, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@saubyk saubyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@Roasbeef
Copy link
Member

Roasbeef commented Dec 2, 2024

Cross compile failed with:

# github.com/lightningnetwork/lnd/funding
compile: writing output: write $WORK/b737/_pkg_.a: no space left on device

Perhaps a cache issue?

@guggero
Copy link
Collaborator Author

guggero commented Dec 2, 2024

Cross compile failed with:

# github.com/lightningnetwork/lnd/funding
compile: writing output: write $WORK/b737/_pkg_.a: no space left on device

Perhaps a cache issue?

Yes, the cache from previous builds plus the current build just grows too large and completely fills the disk.
This is the actual problem this PR attempts to address. Though we will have to clean caches after merging this to get rid of the cached versions of the architectures we remove.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏰

@Roasbeef Roasbeef merged commit ff2a1a4 into lightningnetwork:master Dec 3, 2024
26 of 34 checks passed
@guggero guggero deleted the cross-compile-fix branch December 3, 2024 11:06
@guggero
Copy link
Collaborator Author

guggero commented Dec 3, 2024

Dropped all caches from the GitHub builds now, let's see if that fixes the "cross compile" step in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants