-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build+lnd+docs: start using slog and add commit_hash to log lines #9314
Commits on Nov 29, 2024
-
tools/linters: Add copied golangci-lint
lll
linter codeIn this commit, we copy the implementation of the golangci-lint lll linter which we currently use in our CI flow during the `make lint` check. This commit copies the code mostly as is (the only exception being the line which trims white space before checking if a line starts with "import"), and formats it to fit our codebase guidelines. A test is also added so that we can be sure that the following commits which adjust the implementation have the intended results. The custom linter is put into its own module as this is requied by the `golangci-lint custom` when building the custom linter binary which includes the plugin.
Configuration menu - View commit details
-
Copy full SHA for acbcb77 - Browse repository at this point
Copy the full SHA acbcb77View commit details -
tools/linters: convert to LinterPlugin implementation
This commit introduces the `LLPlugin` type and converts the existing lll code such that the LLPlugin implements the register.LinterPlugin interface. This will allow us to plug it into golangci-linter as a plugin.
Configuration menu - View commit details
-
Copy full SHA for 9637a81 - Browse repository at this point
Copy the full SHA 9637a81View commit details
Commits on Dec 2, 2024
-
tools/linters: ignore log lines
This commit adds a feature to our custom lll linter which will ignore log lines (both single and multi-lined log lines) for the lll linter.
Configuration menu - View commit details
-
Copy full SHA for bd55b27 - Browse repository at this point
Copy the full SHA bd55b27View commit details -
tools+.: add custom linter configuration file
Add this file both to the main LND directory so that devs can use it for local linter runs and also add it to the `tools` directory so that the docker environment used to run the linter in CI has access to it. A custom linter binary can be built via `golangci-lint custom`. This will pull in and register all the plugins listed in the new config file when building the new binary. The new binary can then be run using `custom-gcl run`.
Configuration menu - View commit details
-
Copy full SHA for 88f5369 - Browse repository at this point
Copy the full SHA 88f5369View commit details -
multi: rename nolint:lll to nolint:ll
Find and replace all nolint instances refering to the `lll` linter and replace with `ll` which is the name of our custom version of the `lll` linter which can be used to ignore log lines during linting. The next commit will do the configuration of the custom linter and disable the default one.
Configuration menu - View commit details
-
Copy full SHA for ab7aae0 - Browse repository at this point
Copy the full SHA ab7aae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5d849e - Browse repository at this point
Copy the full SHA c5d849eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a04f8df - Browse repository at this point
Copy the full SHA a04f8dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for efe08b8 - Browse repository at this point
Copy the full SHA efe08b8View commit details -
build: Append commit hash to the main LND context
It can be disabled via the new `logging.no-commit-hash` config option.
Configuration menu - View commit details
-
Copy full SHA for 755ad49 - Browse repository at this point
Copy the full SHA 755ad49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32fbea2 - Browse repository at this point
Copy the full SHA 32fbea2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed4279b - Browse repository at this point
Copy the full SHA ed4279bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8862ce9 - Browse repository at this point
Copy the full SHA 8862ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for afbb9aa - Browse repository at this point
Copy the full SHA afbb9aaView commit details