-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply 8644 on 9260 #9313
base: yy-beat-itest-optimize
Are you sure you want to change the base?
Reapply 8644 on 9260 #9313
Commits on Nov 25, 2024
-
sweep: add new state
TxFatal
for erroneous sweepingsAlso updated the loggings. This new state will be used in the following commit.
Configuration menu - View commit details
-
Copy full SHA for d361ba6 - Browse repository at this point
Copy the full SHA d361ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2217843 - Browse repository at this point
Copy the full SHA 2217843View commit details -
sweep: add new interface method
Immediate
This prepares the following commit where we now let the fee bumpr decides whether to broadcast immediately or not.
Configuration menu - View commit details
-
Copy full SHA for d51bde9 - Browse repository at this point
Copy the full SHA d51bde9View commit details -
sweep: handle inputs locally instead of relying on the tx
This commit changes how inputs are handled upon receiving a bump result. Previously the inputs are taken from the `BumpResult.Tx`, which is now instead being handled locally as we will remember the input set when sending the bump request, and handle this input set when a result is received.
Configuration menu - View commit details
-
Copy full SHA for be1ec51 - Browse repository at this point
Copy the full SHA be1ec51View commit details -
sweep: add
handleInitialBroadcast
to handle initial broadcastThis commit adds a new method `handleInitialBroadcast` to handle the initial broadcast. Previously we'd broadcast immediately inside `Broadcast`, which soon will not work after the `blockbeat` is implemented as the action to publish is now always triggered by a new block. Meanwhile, we still keep the option to bypass the block trigger so users can broadcast immediately by setting `Immediate` to true.
Configuration menu - View commit details
-
Copy full SHA for 075e31e - Browse repository at this point
Copy the full SHA 075e31eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3671a38 - Browse repository at this point
Copy the full SHA 3671a38View commit details -
sweep: add method
handleBumpEventError
and fixmarkInputFailed
Previously in `markInputFailed`, we'd remove all inputs under the same group via `removeExclusiveGroup`. This is wrong as when the current sweep fails for this input, it shouldn't affect other inputs.
Configuration menu - View commit details
-
Copy full SHA for da3a6ab - Browse repository at this point
Copy the full SHA da3a6abView commit details -
sweep: add method
isMature
onSweeperInput
Also updated `handlePendingSweepsReq` to skip immature inputs so the returned results are the same as those in pre-0.18.0.
Configuration menu - View commit details
-
Copy full SHA for 37536c7 - Browse repository at this point
Copy the full SHA 37536c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for de76205 - Browse repository at this point
Copy the full SHA de76205View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0216b9c - Browse repository at this point
Copy the full SHA 0216b9cView commit details -
sweep: break
initialBroadcast
into two stepsWith the combination of the following commit we can have a more granular control over the bump result when handling it in the sweeper.
Configuration menu - View commit details
-
Copy full SHA for 4abd9ba - Browse repository at this point
Copy the full SHA 4abd9baView commit details -
sweep: make sure nil tx is handled
After previous commit, it should be clear that the tx may be failed to created in a `TxFailed` event. We now make sure to catch it to avoid panic.
Configuration menu - View commit details
-
Copy full SHA for e783439 - Browse repository at this point
Copy the full SHA e783439View commit details -
chainio: introduce
chainio
to handle block synchronizationThis commit inits the package `chainio` and defines the interface `Blockbeat` and `Consumer`. The `Consumer` must be implemented by other subsystems if it requires block epoch subscription.
Configuration menu - View commit details
-
Copy full SHA for 46e0a43 - Browse repository at this point
Copy the full SHA 46e0a43View commit details -
In this commit, a minimal implementation of `Blockbeat` is added to synchronize block heights, which will be used in `ChainArb`, `Sweeper`, and `TxPublisher` so blocks are processed sequentially among them.
Configuration menu - View commit details
-
Copy full SHA for c77c230 - Browse repository at this point
Copy the full SHA c77c230View commit details -
chainio: add helper methods to dispatch beats
This commit adds two methods to handle dispatching beats. These are exported methods so other systems can send beats to their managed subinstances.
Configuration menu - View commit details
-
Copy full SHA for 08520b0 - Browse repository at this point
Copy the full SHA 08520b0View commit details -
chainio: add
BlockbeatDispatcher
to dispatch blockbeatsThis commit adds a blockbeat dispatcher which handles sending new blocks to all subscribed consumers.
Configuration menu - View commit details
-
Copy full SHA for 0fa9406 - Browse repository at this point
Copy the full SHA 0fa9406View commit details -
Configuration menu - View commit details
-
Copy full SHA for 029aa31 - Browse repository at this point
Copy the full SHA 029aa31View commit details -
multi: implement
Consumer
on subsystemsThis commit implements `Consumer` on `TxPublisher`, `UtxoSweeper`, `ChainArbitrator` and `ChannelArbitrator`.
Configuration menu - View commit details
-
Copy full SHA for 26e034a - Browse repository at this point
Copy the full SHA 26e034aView commit details -
sweep: remove block subscription in
UtxoSweeper
andTxPublisher
This commit removes the independent block subscriptions in `UtxoSweeper` and `TxPublisher`. These subsystems now listen to the `BlockbeatChan` for new blocks.
Configuration menu - View commit details
-
Copy full SHA for a00120f - Browse repository at this point
Copy the full SHA a00120fView commit details -
sweep: remove redundant notifications during shutdown
This commit removes the hack introduced in lightningnetwork#4851. Previously we had this issue because the chain notifier was stopped before the sweeper, which was changed a while back and we now always stop the chain notifier last. In addition, since we no longer subscribe to the block epoch chan directly, this issue can no longer happen.
Configuration menu - View commit details
-
Copy full SHA for 36ef0c3 - Browse repository at this point
Copy the full SHA 36ef0c3View commit details -
contractcourt: remove
waitForHeight
in resolversThe sweeper can handle the waiting so there's no need to wait for blocks inside the resolvers. By offering the inputs prior to their mature heights also guarantees the inputs with the same deadline are aggregated.
Configuration menu - View commit details
-
Copy full SHA for bb78060 - Browse repository at this point
Copy the full SHA bb78060View commit details -
contractcourt: remove block subscription in chain arbitrator
This commit removes the block subscriptions used in `ChainArbitrator` and replaced them with the blockbeat managed by `BlockbeatDispatcher`.
Configuration menu - View commit details
-
Copy full SHA for 58153f7 - Browse repository at this point
Copy the full SHA 58153f7View commit details -
contractcourt: remove block subscription in channel arbitrator
This commit removes the block subscriptions used in `ChannelArbitrator`, replaced them with the blockbeat managed by `BlockbeatDispatcher`.
Configuration menu - View commit details
-
Copy full SHA for 981e9c2 - Browse repository at this point
Copy the full SHA 981e9c2View commit details -
contractcourt: remove the
immediate
param used inResolve
This `immediate` flag was added as a hack so during a restart, the pending resolvers would offer the inputs to the sweeper and ask it to sweep them immediately. This is no longer need due to `blockbeat`, as now during restart, a block is always sent to all subsystems via the flow `ChainArb` -> `ChannelArb` -> resolvers -> sweeper. Thus, when there are pending inputs offered, they will be processed by the sweeper immediately.
Configuration menu - View commit details
-
Copy full SHA for e3167ca - Browse repository at this point
Copy the full SHA e3167caView commit details -
contractcourt: start channel arbitrator with blockbeat
To avoid calling GetBestBlock again.
Configuration menu - View commit details
-
Copy full SHA for a24ca9e - Browse repository at this point
Copy the full SHA a24ca9eView commit details -
multi: start consumers with a starting blockbeat
This is needed so the consumers have an initial state about the current block.
Configuration menu - View commit details
-
Copy full SHA for 952869c - Browse repository at this point
Copy the full SHA 952869cView commit details -
lnd: add new method
startLowLevelServices
In this commit we start to break up the starting process into smaller pieces, which is needed in the following commit to initialize blockbeat consumers.
Configuration menu - View commit details
-
Copy full SHA for bb42ff5 - Browse repository at this point
Copy the full SHA bb42ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1292c9b - Browse repository at this point
Copy the full SHA 1292c9bView commit details -
contractcourt: fix linter
funlen
Refactor the `Start` method to fix the linter error: ``` contractcourt/chain_arbitrator.go:568: Function 'Start' is too long (242 > 200) (funlen) ```
Configuration menu - View commit details
-
Copy full SHA for ac409a0 - Browse repository at this point
Copy the full SHA ac409a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4005e2a - Browse repository at this point
Copy the full SHA 4005e2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b3b60c - Browse repository at this point
Copy the full SHA 5b3b60cView commit details -
contractcourt: add verbose logging in resolvers
We now put the outpoint in the resolvers's logging so it's easier to debug. Also use the short channel ID whenever possible to shorten the log line length.
Configuration menu - View commit details
-
Copy full SHA for 660fa82 - Browse repository at this point
Copy the full SHA 660fa82View commit details -
contractcourt: add spend path helpers in timeout/success resolver
This commit adds a few helper methods to decide how the htlc output should be spent.
Configuration menu - View commit details
-
Copy full SHA for cd1a184 - Browse repository at this point
Copy the full SHA cd1a184View commit details -
contractcourt: add sweep senders in
htlcSuccessResolver
This commit is a pure refactor in which moves the sweep handling logic into the new methods.
Configuration menu - View commit details
-
Copy full SHA for 91cd342 - Browse repository at this point
Copy the full SHA 91cd342View commit details -
contractcourt: add resolver handlers in
htlcSuccessResolver
This commit refactors the `Resolve` method by adding two resolver handlers to handle waiting for spending confirmations.
Configuration menu - View commit details
-
Copy full SHA for a5c05ae - Browse repository at this point
Copy the full SHA a5c05aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1a9e6d - Browse repository at this point
Copy the full SHA f1a9e6dView commit details -
contractcourt: add sweep senders in
htlcTimeoutResolver
This commit adds new methods to handle making sweep requests based on the spending path used by the outgoing htlc output.
Configuration menu - View commit details
-
Copy full SHA for 982470c - Browse repository at this point
Copy the full SHA 982470cView commit details -
contractcourt: add methods to checkpoint states
This commit adds checkpoint methods in `htlcTimeoutResolver`, which are similar to those used in `htlcSuccessResolver`.
Configuration menu - View commit details
-
Copy full SHA for dda8208 - Browse repository at this point
Copy the full SHA dda8208View commit details -
contractcourt: add resolve handlers in
htlcTimeoutResolver
This commit adds more methods to handle resolving the spending of the output based on different spending paths.
Configuration menu - View commit details
-
Copy full SHA for fab3acf - Browse repository at this point
Copy the full SHA fab3acfView commit details -
contractcourt: add
Launch
method to anchor/breach resolverWe will use this and its following commits to break the original `Resolve` methods into two parts - the first part is moved to a new method `Launch`, which handles sending a sweep request to the sweeper. The second part remains in `Resolve`, which is mainly waiting for a spending tx. Breach resolver currently doesn't do anything in its `Launch` since the sweeping of justice outputs are not handled by the sweeper yet.
Configuration menu - View commit details
-
Copy full SHA for 0d5908e - Browse repository at this point
Copy the full SHA 0d5908eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e75f396 - Browse repository at this point
Copy the full SHA e75f396View commit details -
contractcourt: add
Launch
method to htlc success resolverThis commit breaks the `Resolve` into two parts - the first part is moved into a `Launch` method that handles sending sweep requests, and the second part remains in `Resolve` which handles waiting for the spend. Since we are using both utxo nursery and sweeper at the same time, to make sure this change doesn't break the existing behavior, we implement the `Launch` as following, - zero-fee htlc - handled by the sweeper - direct output from the remote commit - handled by the sweeper - legacy htlc - handled by the utxo nursery
Configuration menu - View commit details
-
Copy full SHA for aa7fcd0 - Browse repository at this point
Copy the full SHA aa7fcd0View commit details -
contractcourt: add
Launch
method to htlc timeout resolverThis commit breaks the `Resolve` into two parts - the first part is moved into a `Launch` method that handles sending sweep requests, and the second part remains in `Resolve` which handles waiting for the spend. Since we are using both utxo nursery and sweeper at the same time, to make sure this change doesn't break the existing behavior, we implement the `Launch` as following, - zero-fee htlc - handled by the sweeper - direct output from the remote commit - handled by the sweeper - legacy htlc - handled by the utxo nursery
Configuration menu - View commit details
-
Copy full SHA for 9ade1ef - Browse repository at this point
Copy the full SHA 9ade1efView commit details -
invoices: exit early when the subscriber chan is nil
When calling `NotifyExitHopHtlc` it is allowed to pass a chan to subscribe to the HTLC's resolution when it's settled. However, this method will also return immediately if there's already a resolution, which means it behaves like a notifier and a getter. If the caller decides to only use the getter to do a non-blocking lookup, it can pass a nil subscriber chan to bypass the notification.
Configuration menu - View commit details
-
Copy full SHA for cea75bf - Browse repository at this point
Copy the full SHA cea75bfView commit details -
contractcourt: add
Launch
method to incoming contest resolverA minor refactor is done to support implementing `Launch`.
Configuration menu - View commit details
-
Copy full SHA for 566eb80 - Browse repository at this point
Copy the full SHA 566eb80View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4e8e75 - Browse repository at this point
Copy the full SHA f4e8e75View commit details -
contractcourt: fix concurrent access to
resolved
This commit makes `resolved` an atomic bool to avoid data race. This field is now defined in `contractResolverKit` to avoid code duplication.
Configuration menu - View commit details
-
Copy full SHA for 600732e - Browse repository at this point
Copy the full SHA 600732eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d1e81b - Browse repository at this point
Copy the full SHA 0d1e81bView commit details -
contractcourt: break
launchResolvers
into two stepsIn this commit, we break the old `launchResolvers` into two steps - step one is to launch the resolvers synchronously, and step two is to actually waiting for the resolvers to be resolved. This is critical as in the following commit we will require the resolvers to be launched at the same blockbeat when a force close event is sent by the chain watcher.
Configuration menu - View commit details
-
Copy full SHA for aeafa63 - Browse repository at this point
Copy the full SHA aeafa63View commit details -
contractcourt: offer outgoing htlc one block earlier before its expiry
We need to offer the outgoing htlc one block earlier to make sure when the expiry height hits, the sweeper will not miss sweeping it in the same block. This also means the outgoing contest resolver now only does one thing - watch for preimage spend till height expiry-1, which can easily be moved into the timeout resolver instead in the future.
Configuration menu - View commit details
-
Copy full SHA for 29521a1 - Browse repository at this point
Copy the full SHA 29521a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 097079e - Browse repository at this point
Copy the full SHA 097079eView commit details -
contractcourt: register spend notification during init
This commit moves the creation of the spending notification from `Start` to `newChainWatcher` so we subscribe the spending event before handling the block, which is needed to properly handle the blockbeat.
Configuration menu - View commit details
-
Copy full SHA for 8f6f9e2 - Browse repository at this point
Copy the full SHA 8f6f9e2View commit details -
contractcourt: add method
handleCommitSpend
To prepare for the blockbeat handler.
Configuration menu - View commit details
-
Copy full SHA for 6870b73 - Browse repository at this point
Copy the full SHA 6870b73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9631dbb - Browse repository at this point
Copy the full SHA 9631dbbView commit details -
contractcourt: notify blockbeat for
chainWatcher
We now start notifying the blockbeat from the ChainArbitrator to the chainWatcher.
Configuration menu - View commit details
-
Copy full SHA for ca92160 - Browse repository at this point
Copy the full SHA ca92160View commit details -
contractcourt: provide a shortcut to
ChannelPoint
This way the log lines are shorten.
Configuration menu - View commit details
-
Copy full SHA for 530ac1b - Browse repository at this point
Copy the full SHA 530ac1bView commit details -
multi: add new method
ChainArbitrator.RedispatchBlockbeat
This commit adds a new method to enable us resending the blockbeat in `ChainArbitrator`, which is needed for the channel restore as the chain watcher and channel arbitrator are added after the start of the chain arbitrator.
Configuration menu - View commit details
-
Copy full SHA for 808e3a6 - Browse repository at this point
Copy the full SHA 808e3a6View commit details -
contractcourt: add close event handlers in
ChannelArbitrator
To prepare the next commit where we would handle the event upon receiving a blockbeat.
Configuration menu - View commit details
-
Copy full SHA for 651d4d4 - Browse repository at this point
Copy the full SHA 651d4d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b058383 - Browse repository at this point
Copy the full SHA b058383View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d48f0c - Browse repository at this point
Copy the full SHA 3d48f0cView commit details -
chainntnfs: skip dispatched conf details
We need to check `dispatched` before sending conf details, otherwise the channel `ntfn.Event.Confirmed` will be blocking, which is the leftover from lightningnetwork#9275.
Configuration menu - View commit details
-
Copy full SHA for d785469 - Browse repository at this point
Copy the full SHA d785469View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c9c6d0 - Browse repository at this point
Copy the full SHA 5c9c6d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9757c4b - Browse repository at this point
Copy the full SHA 9757c4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bd342e - Browse repository at this point
Copy the full SHA 9bd342eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72e17a4 - Browse repository at this point
Copy the full SHA 72e17a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3023c35 - Browse repository at this point
Copy the full SHA 3023c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79a8260 - Browse repository at this point
Copy the full SHA 79a8260View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29bb9b8 - Browse repository at this point
Copy the full SHA 29bb9b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d116a56 - Browse repository at this point
Copy the full SHA d116a56View commit details -
lntest+itest: start flattening the multi-hop tests
Starting from this commit, we begin the process of flattening the multi-hop itests to make them easier to be maintained. The tests are refactored into their own test cases, with each test focusing on testing one channel type. This is necessary to save effort for future development. These tests are also updated to reflect the new `blockbeat` behavior.
Configuration menu - View commit details
-
Copy full SHA for 50d8d75 - Browse repository at this point
Copy the full SHA 50d8d75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1607d4b - Browse repository at this point
Copy the full SHA 1607d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d3b28b - Browse repository at this point
Copy the full SHA 2d3b28bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 493650e - Browse repository at this point
Copy the full SHA 493650eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c50559 - Browse repository at this point
Copy the full SHA 6c50559View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa0ca88 - Browse repository at this point
Copy the full SHA aa0ca88View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdca3af - Browse repository at this point
Copy the full SHA bdca3afView commit details -
itest: flatten
testHtlcTimeoutResolverExtractPreimageLocal
This commit simplfies the test since we only test the preimage extraction logic in the htlc timeout resolver, there's no need to test it for all different channel types as the resolver is made to be oblivious about them.
Configuration menu - View commit details
-
Copy full SHA for 291919a - Browse repository at this point
Copy the full SHA 291919aView commit details -
itest: flatten
testHtlcTimeoutResolverExtractPreimageRemote
Also remove unused code.
Configuration menu - View commit details
-
Copy full SHA for 6db372c - Browse repository at this point
Copy the full SHA 6db372cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 820a4e5 - Browse repository at this point
Copy the full SHA 820a4e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5581c7a - Browse repository at this point
Copy the full SHA 5581c7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35aa809 - Browse repository at this point
Copy the full SHA 35aa809View commit details -
Configuration menu - View commit details
-
Copy full SHA for fda9ef1 - Browse repository at this point
Copy the full SHA fda9ef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70c2f3f - Browse repository at this point
Copy the full SHA 70c2f3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 241da54 - Browse repository at this point
Copy the full SHA 241da54View commit details -
itest+lntest: fix channel force close test
Also flatten the tests to make them easier to be maintained.
Configuration menu - View commit details
-
Copy full SHA for b3a1489 - Browse repository at this point
Copy the full SHA b3a1489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cf665d - Browse repository at this point
Copy the full SHA 6cf665dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 897803b - Browse repository at this point
Copy the full SHA 897803bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7d5c1 - Browse repository at this point
Copy the full SHA fe7d5c1View commit details -
lntest+itest: remove the usage of
ht.AssertActiveHtlcs
The method `AssertActiveHtlcs` is now removed due to it's easy to be misused. To assert a given htlc, use `AssertOutgoingHTLCActive` and `AssertIncomingHTLCActive` instead for ensuring the HTLC exists in the right direction. Although often the case `AssertNumActiveHtlcs` would be enough as it implicitly checks the forwarding behavior for an intermediate node by asserting there are always num_payment*2 HTLCs.
Configuration menu - View commit details
-
Copy full SHA for b8da896 - Browse repository at this point
Copy the full SHA b8da896View commit details -
htlcswitch: handle nil circuit properly when settling
We have two sources which can call `handlePacketSettle`, either through the link's `<-s.htlcPlex`, or the `<-s.resolutionMsgs`, which means the `closeCircuit` could be call twice. Previously we already caught this case inside `closeCircuit`, in that we would return a nil circuit upon seeing `ErrUnknownCircuit`, indicating the circuit was removed. However, we still need to account the case when the circuit is being closed, which is now fixed as we will ignore when seeing `ErrCircuitClosing`.
Configuration menu - View commit details
-
Copy full SHA for 84c8aa6 - Browse repository at this point
Copy the full SHA 84c8aa6View commit details
Commits on Nov 26, 2024
-
routing: fix nil pointer dereference in
exitWithErr
In a rare case when the critical log is triggered when using postgres as db backend, the `payment` could be nil cause the server is shutting down, causing the payment fetching to return an error. We now cache its state before fetching it from the db.
Configuration menu - View commit details
-
Copy full SHA for f777264 - Browse repository at this point
Copy the full SHA f777264View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0725cb5 - Browse repository at this point
Copy the full SHA 0725cb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13ef2ee - Browse repository at this point
Copy the full SHA 13ef2eeView commit details -
itest: shuffle test cases to even out blocks mined in tranches
This commit adds a new flag to shuffle all the test cases before running them so tests which require lots of blocks to be mined are less likely to be run in the same tranch. The other benefit is this approach provides a more efficient way to figure which tests are broken since all the differnet backends are running different tranches in their builds, we can identify more failed tests in one push.
Configuration menu - View commit details
-
Copy full SHA for bbc4945 - Browse repository at this point
Copy the full SHA bbc4945View commit details -
workflows: pass action ID as the shuffle seed
To make sure each run is shuffled, we use the action ID as the seed.
Configuration menu - View commit details
-
Copy full SHA for a7b69c6 - Browse repository at this point
Copy the full SHA a7b69c6View commit details -
itest: remove direct reference to stanby nodes
Prepares the upcoming refactor. We now never call `ht.Alice` directly, instead, we always init `alice := ht.Alice` so it's easier to see how they are removed in a following commit.
Configuration menu - View commit details
-
Copy full SHA for cffea2f - Browse repository at this point
Copy the full SHA cffea2fView commit details -
itest: remove the use of standby nodes
This commit removes the usage of the standby nodes and uses `CreateSimpleNetwork` when applicable. Also introduces a helper method `NewNodeWithCoins` to quickly start a node with funds.
Configuration menu - View commit details
-
Copy full SHA for f33e55f - Browse repository at this point
Copy the full SHA f33e55fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a743f4 - Browse repository at this point
Copy the full SHA 6a743f4View commit details -
itest+lntest: remove standby nodes
This commit removes the standby nodes Alice and Bob.
Configuration menu - View commit details
-
Copy full SHA for b12a16f - Browse repository at this point
Copy the full SHA b12a16fView commit details -
itest: remove unnecessary channel close and node shutdown
Since we don't have standby nodes anymore, we don't need to close the channels when the test finishes. Previously we would do so to make sure the standby nodes have a clean state for the next test case, which is no longer relevant.
Configuration menu - View commit details
-
Copy full SHA for 6d3ed89 - Browse repository at this point
Copy the full SHA 6d3ed89View commit details -
lntest: make sure node is properly shut down
Soemtimes the node may be hanging for a while without being noticed, causing failures in its following tests, thus making the debugging extrememly difficult. We now assert the node has been shut down from the logs to assert the shutdown process behaves as expected.
Configuration menu - View commit details
-
Copy full SHA for 822b71a - Browse repository at this point
Copy the full SHA 822b71aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0019cb3 - Browse repository at this point
Copy the full SHA 0019cb3View commit details -
itest: fix
testOpenChannelUpdateFeePolicy
This commit fixes a misuse of `ht.Subtest`, where the nodes should always be created inside the subtest.
Configuration menu - View commit details
-
Copy full SHA for 1ffe921 - Browse repository at this point
Copy the full SHA 1ffe921View commit details -
itest: fix flake in
testSendDirectPayment
This bug was hidden because we used standby nodes before, which always have more-than-necessary wallet utxos.
Configuration menu - View commit details
-
Copy full SHA for c6819c0 - Browse repository at this point
Copy the full SHA c6819c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e2495 - Browse repository at this point
Copy the full SHA 50e2495View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71eab38 - Browse repository at this point
Copy the full SHA 71eab38View commit details -
itest: flatten PSBT funding test cases
So it's easier to get the logs and debug.
Configuration menu - View commit details
-
Copy full SHA for 494f1e5 - Browse repository at this point
Copy the full SHA 494f1e5View commit details -
itest: fix and document flake in sweeping tests
We previously didn't see this issue because we always have nodes being over-funded.
Configuration menu - View commit details
-
Copy full SHA for 8082b93 - Browse repository at this point
Copy the full SHA 8082b93View commit details -
itest: remove loop in
wsTestCaseBiDirectionalSubscription
So we know which open channel operation failed.
Configuration menu - View commit details
-
Copy full SHA for 844b100 - Browse repository at this point
Copy the full SHA 844b100View commit details -
itest: fix flake in
testRevokedCloseRetributionZeroValueRemoteOutput
We need to mine an empty block as the tx may already have entered the mempool. This should be fixed once we start using the sweeper to handle the justice tx.
Configuration menu - View commit details
-
Copy full SHA for c270401 - Browse repository at this point
Copy the full SHA c270401View commit details -
itest: fix flake in
testSwitchOfflineDelivery
The reconnection will happen automatically when the nodes have a channel, so we just ensure the connection instead of reconnecting directly.
Configuration menu - View commit details
-
Copy full SHA for c6b7aa7 - Browse repository at this point
Copy the full SHA c6b7aa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dda51c2 - Browse repository at this point
Copy the full SHA dda51c2View commit details -
itest: use
ht.CreateSimpleNetwork
whenever applicableSo we won't forget to assert the topology after opening a chain of channels.
Configuration menu - View commit details
-
Copy full SHA for d388c88 - Browse repository at this point
Copy the full SHA d388c88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45ee9e5 - Browse repository at this point
Copy the full SHA 45ee9e5View commit details -
lntest+itest: remove
AssertNumActiveEdges
This is no longer needed since we don't have standby nodes, plus it's causing panic in windows build due to `edge.Policy` being nil.
Configuration menu - View commit details
-
Copy full SHA for 3c4b63a - Browse repository at this point
Copy the full SHA 3c4b63aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e005582 - Browse repository at this point
Copy the full SHA e005582View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f7d952 - Browse repository at this point
Copy the full SHA 4f7d952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 076885b - Browse repository at this point
Copy the full SHA 076885bView commit details -
lntest: increase
rpcmaxwebsockets
forbtcd
This has been seen in the itest which can lead to the node startup failure, ``` 2024-11-20 18:55:15.727 [INF] RPCS: Max websocket clients exceeded [25] - disconnecting client 127.0.0.1:57224 ```
Configuration menu - View commit details
-
Copy full SHA for cb3b285 - Browse repository at this point
Copy the full SHA cb3b285View commit details -
itest: document details about MPP-related tests
This is needed so we can have one place to fix the flakes found in the MPP-related tests, which is fixed in the following commit.
Configuration menu - View commit details
-
Copy full SHA for a6bbb3f - Browse repository at this point
Copy the full SHA a6bbb3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9c0cd5 - Browse repository at this point
Copy the full SHA f9c0cd5View commit details -
lntest: fix flakeness in
openChannelsForNodes
We now make sure the channel participants have heard their private channel when opening channels.
Configuration menu - View commit details
-
Copy full SHA for d8d2a54 - Browse repository at this point
Copy the full SHA d8d2a54View commit details -
itest: optimize blocks mined in
testGarbageCollectLinkNodes
There's no need to mine 80ish blocks here.
Configuration menu - View commit details
-
Copy full SHA for bdfa085 - Browse repository at this point
Copy the full SHA bdfa085View commit details -
itest: break remote signer into independent cases
So the test can run faster.
Configuration menu - View commit details
-
Copy full SHA for 98c7a92 - Browse repository at this point
Copy the full SHA 98c7a92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 136c6f3 - Browse repository at this point
Copy the full SHA 136c6f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3473ec - Browse repository at this point
Copy the full SHA a3473ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for db84d56 - Browse repository at this point
Copy the full SHA db84d56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 006f656 - Browse repository at this point
Copy the full SHA 006f656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 676b925 - Browse repository at this point
Copy the full SHA 676b925View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b84e60 - Browse repository at this point
Copy the full SHA 6b84e60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27b0489 - Browse repository at this point
Copy the full SHA 27b0489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a08b78 - Browse repository at this point
Copy the full SHA 7a08b78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d1203 - Browse repository at this point
Copy the full SHA 41d1203View commit details -
itest: break down single hop send to route
Also removed the duplicate test cases.
Configuration menu - View commit details
-
Copy full SHA for c0d284c - Browse repository at this point
Copy the full SHA c0d284cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c18e356 - Browse repository at this point
Copy the full SHA c18e356View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce88b8b - Browse repository at this point
Copy the full SHA ce88b8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aace64e - Browse repository at this point
Copy the full SHA aace64eView commit details -
itest: track and skip flaky tests for windows
To make the CI indicative, we now starting tracking the flaky tests found when running on Windows. As a starting point, rather than ignore the windows CI entirely, we now identify there are cases where lnd can be buggy when running in windows. We should fix the tests in the future, otherwise the windows build should be deleted.
Configuration menu - View commit details
-
Copy full SHA for 3535cca - Browse repository at this point
Copy the full SHA 3535ccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d5b36 - Browse repository at this point
Copy the full SHA f2d5b36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f2387 - Browse repository at this point
Copy the full SHA 41f2387View commit details -
Configuration menu - View commit details
-
Copy full SHA for b011d8c - Browse repository at this point
Copy the full SHA b011d8cView commit details -
itest+lntest: add new method
FundNumCoins
Most of the time we only need to fund the node with given number of UTXOs without concerning the amount, so we add the more efficient funding method as it mines a single block in the end.
Configuration menu - View commit details
-
Copy full SHA for be55355 - Browse repository at this point
Copy the full SHA be55355View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87ea4f0 - Browse repository at this point
Copy the full SHA 87ea4f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed3548 - Browse repository at this point
Copy the full SHA 7ed3548View commit details
Commits on Dec 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b645f9c - Browse repository at this point
Copy the full SHA b645f9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70529e1 - Browse repository at this point
Copy the full SHA 70529e1View commit details -
Reapply "kvdb/postgres: remove global application level lock"
This reverts commit 67419a7.
Configuration menu - View commit details
-
Copy full SHA for 563fff9 - Browse repository at this point
Copy the full SHA 563fff9View commit details -
itest: fix flake in multi-hop payments
To make this itest work reliably with multiple parallel SQL transactions, we need to count both the settle and final HTLC events. Otherwise, sometimes the final events from earlier forwards are counted before the forward events from later forwards, causing a miscount of the settle events. If we expect both the settle and final event for each forward, we don't miscount.
Configuration menu - View commit details
-
Copy full SHA for d1d2e20 - Browse repository at this point
Copy the full SHA d1d2e20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 235de40 - Browse repository at this point
Copy the full SHA 235de40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a1817 - Browse repository at this point
Copy the full SHA 77a1817View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9e1fd6 - Browse repository at this point
Copy the full SHA c9e1fd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 440c151 - Browse repository at this point
Copy the full SHA 440c151View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b04232 - Browse repository at this point
Copy the full SHA 3b04232View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cca186 - Browse repository at this point
Copy the full SHA 6cca186View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb50cec - Browse repository at this point
Copy the full SHA fb50cecView commit details