-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: bump btclog dep #9295
go.mod: bump btclog dep #9295
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
02c7363
to
ece61aa
Compare
f07e4da
to
9e302ee
Compare
9e302ee
to
e4476a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
@@ -1,180 +0,0 @@ | |||
package build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice removal 🎉
thanks for the reviews yall! think it needs an override merge cause of the required |
ah - will need to rebase anyways given that #8270 added a prefixed logger |
And instead use the new btclog Logger `WithPrefix` method.
e4476a8
to
c2923e2
Compare
Point to the latest version of the v2 lib which checks log level before calling fmt.Sprint along
with a variety of other performance improvements.
h/t to @bitromortac for finding this! 🙏
NOTE: This has been updated to remove the PrefixLogger as this can now be done via the btclog.Logger's WIthPrefix method