Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynComms [2/n]: lnwire: add authenticated wire messages for Dyn* #9148

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ProofOfKeags
Copy link
Collaborator

@ProofOfKeags ProofOfKeags commented Oct 1, 2024

Change Description

This PR updates the dynamic commitment wire messages to include the new authentication mechanisms.

Stacked on #8270 but does not depend on it.

Steps to Test

TODO: write tests to ensure signing, verification and message composition and decomposition work properly

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

Copy link
Contributor

coderabbitai bot commented Oct 1, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ProofOfKeags ProofOfKeags self-assigned this Oct 1, 2024
@ProofOfKeags ProofOfKeags changed the title Lnwire dyncomms update DynComms [2/n]: lnwire: add authenticated wire messages for Dyn* Oct 1, 2024
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch from 9c3816c to f4c7e0c Compare October 2, 2024 19:00
@ProofOfKeags ProofOfKeags marked this pull request as ready for review October 2, 2024 21:09
@ProofOfKeags ProofOfKeags changed the title DynComms [2/n]: lnwire: add authenticated wire messages for Dyn* DynComms [1/n]: lnwire: add authenticated wire messages for Dyn* Oct 2, 2024
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch 2 times, most recently from 546a4dd to 5885853 Compare October 2, 2024 21:15
@ProofOfKeags ProofOfKeags changed the title DynComms [1/n]: lnwire: add authenticated wire messages for Dyn* DynComms [2/n]: lnwire: add authenticated wire messages for Dyn* Oct 2, 2024
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch from 5885853 to 159c722 Compare October 2, 2024 23:55
@saubyk saubyk added this to the v0.19.0 milestone Oct 3, 2024
@saubyk saubyk requested a review from Crypt-iQ October 3, 2024 15:23
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch 2 times, most recently from 9b351ca to bd77255 Compare October 8, 2024 08:58
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch from bd77255 to dd55c6e Compare October 14, 2024 19:26
lnwire/dyn_propose.go Show resolved Hide resolved
lnwire/dyn_commit.go Outdated Show resolved Hide resolved
lnwire/dyn_commit.go Show resolved Hide resolved
lnwire/dyn_commit.go Outdated Show resolved Hide resolved
lnwire/dyn_ack.go Outdated Show resolved Hide resolved
return err
}

var msg bytes.Buffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not combine all the serialization into a single message for the SigDigest? We do something similar for the gossip messages.

lnwire/dyn_ack.go Outdated Show resolved Hide resolved
lnwire/dyn_propose.go Outdated Show resolved Hide resolved
lnwire/dyn_propose.go Outdated Show resolved Hide resolved
lnwire/dyn_propose.go Outdated Show resolved Hide resolved
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch 6 times, most recently from da6f1b1 to b4c9c48 Compare October 17, 2024 20:56
@ProofOfKeags ProofOfKeags requested a review from Roasbeef October 17, 2024 20:58
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch 2 times, most recently from 93d5633 to 11c97ec Compare October 17, 2024 21:11
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎎

@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch from 11c97ec to a7fe0ab Compare November 20, 2024 20:30
@ProofOfKeags ProofOfKeags force-pushed the lnwire-dyncomms-update branch from a7fe0ab to 5352fed Compare November 27, 2024 21:06
@lightninglabs-deploy
Copy link

@Crypt-iQ: review reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants