-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynComms [2/n]: lnwire: add authenticated wire messages for Dyn* #9148
base: master
Are you sure you want to change the base?
DynComms [2/n]: lnwire: add authenticated wire messages for Dyn* #9148
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
9c3816c
to
f4c7e0c
Compare
546a4dd
to
5885853
Compare
5885853
to
159c722
Compare
9b351ca
to
bd77255
Compare
bd77255
to
dd55c6e
Compare
lnwire/dyn_ack.go
Outdated
return err | ||
} | ||
|
||
var msg bytes.Buffer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not combine all the serialization into a single message for the SigDigest
? We do something similar for the gossip messages.
da6f1b1
to
b4c9c48
Compare
93d5633
to
11c97ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎎
11c97ec
to
a7fe0ab
Compare
a7fe0ab
to
5352fed
Compare
@Crypt-iQ: review reminder |
Change Description
This PR updates the dynamic commitment wire messages to include the new authentication mechanisms.
Stacked on #8270 but does not depend on it.
Steps to Test
TODO: write tests to ensure signing, verification and message composition and decomposition work properly
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.